Giter Club home page Giter Club logo

Comments (7)

nickstenning avatar nickstenning commented on July 17, 2024

Yes, that looks like the ANSI escape sequences to do with colouring. There's currently no command-line option to disable colour, but adding it is probably a relatively simple patch.

from honcho.

apmorton avatar apmorton commented on July 17, 2024

it doesn't look like I can attach a PR to this issue since I didn't open it, but here is my solution to this problem.

Juvenal1228/honcho@98fc31820f991f810f4efcd0028bb0257ac35aad

I don't see the need for a command line argument to disable color since most every shell will handle color fine except on windows. You could also use sys.stdout.isatty() on linux to determine whether or not to use color, since this would allow output redirection for logging etc to work properly and not display the ANSI color escape garbage

from honcho.

pombredanne avatar pombredanne commented on July 17, 2024

@Juvenal1228 : thanks for the patch: this looks good and simple enough yet it likely wrecks havoc in the tests that expect a color escape sequence in the output for now... have you run the tests with this patch?

btw, not being able to attach a commit to an issue is a quirk of github... feel free to start a new pull request and we can ref this issue in the new issue that will be automatically created. there are ways around this explained here FWIW, but this requires extra tool: http://stackoverflow.com/questions/4528869/how-do-you-attach-a-new-pull-request-to-an-existing-issue-on-github

from honcho.

nickstenning avatar nickstenning commented on July 17, 2024

Quick question: won't this disable colour in ANSI-capable shells that happen to be running on Windows? (such as Cygwin bash)

from honcho.

nickstenning avatar nickstenning commented on July 17, 2024

I'm thinking the correct solution here would probably be to depend on colorama which claims to provide cross-platform coloured output just by adding

import colorama
colorama.init()

to Honcho. @pombredanne would you be up for trying this out?

from honcho.

pombredanne avatar pombredanne commented on July 17, 2024

let me try that and report

from honcho.

nickstenning avatar nickstenning commented on July 17, 2024

Finally fixed in v0.6.2 (by a1b2cb5).

from honcho.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.