Comments (6)
Doing window.close(false)
still causes the exploit. So it must be in the body of BaseWindow#close
.
Interestingly enough, while testing I also found another bug. If you do window.close(false)
, close the GUI yourself and then leave, this exception will be thrown:
[18:54:59 WARN]: [ItemDup] Task #25 for ItemDup v1.0 generated an exception
java.lang.IllegalStateException: The Window has already been closed.
at de.studiocode.invui.window.impl.BaseWindow.show(BaseWindow.java:249) ~[itemdup-1.0-all.jar:?]
at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.19.2.jar:git-Paper-160]
at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[paper-1.19.2.jar:git-Paper-160]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1493) ~[paper-1.19.2.jar:git-Paper-160]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.19.2.jar:git-Paper-160]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1417) ~[paper-1.19.2.jar:git-Paper-160]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1193) ~[paper-1.19.2.jar:git-Paper-160]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-160]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
This is a different issue, but this is caused by BaseWindow#handleClose
being called when an inventory is closed (which happens when a player leaves) while it's not closeable (which is why it's being reopened and throws this exception).
from invui.
Should be fixed in c315c36.
Interestingly enough, while testing I also found another bug. If you do window.close(false), close the GUI yourself and then leave, this exception will be thrown
This should also be fixed now. Though, you should never call window.close(false)
(it unregisters all handlers but leaves the inventory open -> players can just take the items from the inventory). It only exists for internal use and shouldn't even be accessible to you, the same goes for all the handle...
methods. I just didn't have the time to clean that stuff up yet.
from invui.
I don't use window.close(false)
myself, it was just something I accidentally stumbled upon while testing if maybe that could be it.
But thanks a lot for fixing it! :)
from invui.
Can the version be bumped? I'll use JitPack for now, but I really think this fix is worth a version bump.
Actually: the JitPack build fails and outputs incomplete artifacts.
from invui.
sure
from invui.
Thanks!
Just tested the latest version and can confirm that it is now fixed. Thanks a lot! :)
from invui.
Related Issues (20)
- HeadTexture#of prints a stacktrace
- NoClassDefFoundError: xyz/xenondevs/invui/item/ItemProvider on Spigot 1.20 HOT 1
- Can't use the dependency in maven for some reason HOT 1
- this.gui.setContent(); alternative and problem with addItems
- Erorr when enable my plugin with invui HOT 4
- Error when use SkullBuilder(uuid) HOT 1
- Paged Tabs GUI support
- Items stay in your inventory after server restart when using multi window HOT 5
- Bold formatting not resetting in lore HOT 2
- [Bug] Wrong version HOT 1
- shadowJar is broken for this library HOT 2
- Paper 1.20.5+ Mojang Mapped runtime issues HOT 5
- Adding api to the server? HOT 1
- Checking if clicking inside player inventory
- Caused by: java.lang.RuntimeException: java.lang.NoClassDefFoundError: net/minecraft/world/entity/player/EntityHuman HOT 6
- Changing Window Title to display new font image
- How do I update every item on a GUI if one item change it status?
- Bold formatting not resetting in lore HOT 1
- Stylable GUI Items HOT 1
- Items saved in player inventory on server crash. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from invui.