Comments (5)
Thanks limsbeheer.
I'm pretty sure that this has already been fixed as a part of c0375c7
I haven't been able to reproduce this locally, are you running version 2.4.0.7? This change should be a part of that release.
from nhapi.
I just downloaded the latest sources (which is 2.4.0.7) with the "Download ZIP" button and built it. Now when I call PipeParser.GetMessageStructureForEvent it still gives me value "ADT_A04" instead of "ADT_A01".
The fix you made in the private constructor is needed to get the package name without trailing dot to load the assembly succesfully. But the dot remains in property package.PackageName.
So when method GetAssemblyEventMapping is called in the constructor, package.EventMappingResourceName still contains "NHapi.Model.V25..EventMapping.EventMap.properties" (with two dots) and therefore variable inResource stays null.
Do you not experience such behaviour?
from nhapi.
Strange ... I'm unable to reproduce this however the problem may lie with my test method?
Here's what I'm running locally to verify this:
[Test]
public void TestAdtA04AndA01MessageStructure()
{
var result = PipeParser.GetMessageStructureForEvent("ADT_A04", "2.5");
Assert.AreSame("ADT_A04", result);
result = PipeParser.GetMessageStructureForEvent("ADT_A01", "2.5");
Assert.AreSame("ADT_A01", result);
}
Does this differ from what you are attempting to run?
from nhapi.
Yes: input value "ADT_A04" should yield "ADT_A01" since A01 is the structure for event A04. So the first Assert should be: Assert.AreSame("ADT_A01", result);
The second assert is correct: A01 is the structure for event A01.
Other events which use the A01 structure are A08 and A13.
from nhapi.
Ahhh... it all makes sense now. I misread it the other way around and as such my tests weren't reporting back any errors as you can tell.
You're right, I'll strip out the prepending '.' from the EventMappingResourceName getter which will make the assembly load as it should.
I'll put this fix in the next release, A04's, A13's and A08's are now returning A01 as expected.
from nhapi.
Related Issues (20)
- Support inserting custom logging framework HOT 4
- `ORL_O34` structure definition contains cyclic reference HOT 5
- Include the optional `LongName` attribute in the XML encoded output. HOT 7
- Add CharSetUtil and PreParser for parsing MSH-18 charset before main parsing HOT 17
- Cannot get ODS segment using terser, when I write a full path HOT 7
- Self referencing loop detected HOT 1
- Incorrect repeat counts for OBX-8/9/10/16 in v2.4 HOT 10
- ADT_A28 / ADT_A31 / ADT_A47 missed since v2.4 HOT 4
- nHapi returns error for valid HL7 files while doing validation concurrently HOT 6
- Review `ParserBase` member access modifiers to ensure they match those in `hapi`.
- Port `Version` from `hapi`.
- In NHapi.Model.V23.Segment.STF the type of Phone is TN this is not correct According to the standard it should be XTN HOT 1
- Mindray Datetime Format HOT 3
- Exception adding an escaped string as field to Segment HOT 7
- support for Fast Healthcare Interoperability Resources (FHIR) HOT 3
- QRF-5 ExtraComponents HOT 8
- Get property names that have no data while parsing to XML. HOT 2
- getting exceptions trying to compile vb.net project against nhapi 3.2 (in c# it probably would have been ok but we are using vb.net) HOT 5
- Unexpected GMTOffset when field contains date only HOT 1
- NativeAOT HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhapi.