Compatibility with NgxsModule's developmentMode about entity-state HOT 8 CLOSED

developmentMode recursively freezes the state. While the state after every action should be a new one, the action handlers use mutability while applying their logic. This is my guess.
I will look into it.

from entity-state.

What kind of entities do you have on your store? Can you paste your state class, including @State annotation?

from entity-state.

As far as I can tell, there is nothing special about it.
The model is just a plain object.

@State<EntityStateModel<IFoo>>({
  name: "foos",
  defaults: defaultEntityState()
})
export class FooState extends EntityState<IFoo> {

  constructor() {
    super(FooState, "id", UUIDV1IdGenerator);
  }

  onUpdate(current: Readonly<IFoo>, updated: Partial<IFoo>): IFoo {
    return {...current, ...updated};
  }
}

The error message seems to indicate, that the problem happens when the entities map is updated.

core.js:15714 ERROR TypeError: Cannot add property 930ec024-e23c-4d3a-91bd-619a6dbe7c0a, object is not extensible
    at ngxs-labs-entity-state.js:1107
    at Array.forEach (<anonymous>)
    at FooState.push../node_modules/@foo/ngxs-labs-entity-state/fesm5/ngxs-labs-entity-state.js.EntityState._addOrReplace (ngxs-labs-entity-state.js:1103)
    at FooState.push../node_modules/@foo/ngxs-labs-entity-state/fesm5/ngxs-labs-entity-state.js.EntityState.add (ngxs-labs-entity-state.js:777)
    at StateFactory.push../node_modules/@ngxs/store/fesm5/ngxs-store.js.StateFactory.invokeActions (ngxs-store.js:1475)
    at MergeMapSubscriber.project (ngxs-store.js:1401)

from entity-state.

What does IFoo look like?

from entity-state.

It doesn't really matter, some interface with a id: string and whatever else you want to add.
The problem occurs when an entity gets added to the entities HashMap after EntityState.add is invoked.

It would be good if there were some alpha/beta releases on NPM, didn't manage to add this stackblitz atm.

from entity-state.

@JanMalch This is fixed with #98?

from entity-state.

It will be, as soon as the refactor/immutability branch is merged. It was planned to develop the entity state operators (#85) in there aswell. But I will create a PR for the branch now and open a new one for state operators.

from entity-state.

Hello @JanMalch @splincode ,
Can you update npm "@ngxs-labs/entity-state". I am getting the error.

Thank you

from entity-state.