Comments (9)
test failure reason was Jasmin types version, I have fixed it and opened a PR #11
from entity-state.
@eranshmil yes you are right, I have removed it :)
from entity-state.
Had Angular 6 as a peer dependency until 940de87. Tests didn't run. Bumping the Angular version fixed it.
@ngxs/store dependency is a good point. How far down would you go, when it's running?
from entity-state.
Did you figure out why it was failing and why the upgrade fixed that?
Maybe it can be solved other way.
About NGXS, my guess it will work no matter what, but in my opinion, it will be enough to support all 3.x versions. And of course, it needs to be checked.
from entity-state.
Although it would be great to support all 3.x versions I think that it would be safe to assume that anyone using this library is probably just setting up or is happy to upgrade. Regarding the Angular 7 dependency I think that is important to investigate
from entity-state.
Great! But you don't have to revert the main package.json, only the peerDependencies.
from entity-state.
What's the usual (CI) procedure for testing support of dependency versions? I mean I can't just lower the version number without confirming that it works with both ng6 and ng7 in the integration test?
from entity-state.
need to create separate tags and branches for each angular version, for example,
entity-state@6 -> angular6
entity-state@7 -> angular7
and I think need to be maintained only last version
from entity-state.
I guess this issue isn't relevant anymore.
from entity-state.
Related Issues (20)
- Help request / question => how to get an entity by id? HOT 3
- Feature/Discussion: Collection Sort/Filter HOT 3
- Provide beta release? HOT 15
- Behaviour of remove action HOT 5
- Switch to Jest test framework
- EntityState selectors recalculate when any part of root state was updated HOT 7
- Joining Selectors of two EntityState not working
- Make pagination feature optional HOT 2
- Expose internal.ts to public to easily extend EntityState using same logic HOT 8
- Angular 9 upgrade blocked HOT 2
- Allow numbers as keys HOT 2
- Error: Attempted to get members of a non-class: class Add - NGCC HOT 3
- could not get librabry folder in my project HOT 3
- Adding Api Response to Entities HOT 3
- Change UMD Bundling from ES2015 to ES5? HOT 6
- [Feature request] IdStrategy with nested keys
- State of the library HOT 2
- Provide filter operators for actions e.g. ofEntityAction HOT 1
- Migrate to State Operators HOT 2
- Not working developmentMode, getting ERROR TypeError: Cannot add property VALUE_OF_ID, object is not extensible HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from entity-state.