Library's peerDependencies about entity-state HOT 9 CLOSED

test failure reason was Jasmin types version, I have fixed it and opened a PR #11

from entity-state.

@eranshmil yes you are right, I have removed it :)

from entity-state.

Had Angular 6 as a peer dependency until 940de87. Tests didn't run. Bumping the Angular version fixed it.
@ngxs/store dependency is a good point. How far down would you go, when it's running?

from entity-state.

Did you figure out why it was failing and why the upgrade fixed that?
Maybe it can be solved other way.

About NGXS, my guess it will work no matter what, but in my opinion, it will be enough to support all 3.x versions. And of course, it needs to be checked.

from entity-state.

Although it would be great to support all 3.x versions I think that it would be safe to assume that anyone using this library is probably just setting up or is happy to upgrade. Regarding the Angular 7 dependency I think that is important to investigate

from entity-state.

Great! But you don't have to revert the main package.json, only the peerDependencies.

from entity-state.

What's the usual (CI) procedure for testing support of dependency versions? I mean I can't just lower the version number without confirming that it works with both ng6 and ng7 in the integration test?

from entity-state.

need to create separate tags and branches for each angular version, for example,
entity-state@6 -> angular6
entity-state@7 -> angular7
and I think need to be maintained only last version

from entity-state.

I guess this issue isn't relevant anymore.

from entity-state.