Giter Club home page Giter Club logo

Comments (5)

nguyenhuy avatar nguyenhuy commented on June 29, 2024

@StrauneanuDimitri Thanks for trying out this library and reporting this issue. If you press the back button while the collection view is still scrolling, the view will stop scrolling and try to notify its delegate, which has already been deallocated. Thus, a crash occurs.

Could you try to manually set the collection view's delegate to nil right before the delegate itself is deallocated? In my example, ViewController is a (dummy) ASCollectionViewDelegate, so this piece of code in ViewController.swift should work:

    deinit {
        collectionView.asyncDelegate = nil
    }

from asyncmessagesviewcontroller.

nguyenhuy avatar nguyenhuy commented on June 29, 2024

P/S: I believe the problem is caused by ASDK itself (facebookarchive/AsyncDisplayKit#721) and should be fixed once facebookarchive/AsyncDisplayKit#790 is landed. Until then, we need to nil a weak reference ourselves :(

from asyncmessagesviewcontroller.

StrauneanuDimitri avatar StrauneanuDimitri commented on June 29, 2024

Yes, it's working now. Much appreciated for that code. This is a fantastic library!

from asyncmessagesviewcontroller.

nguyenhuy avatar nguyenhuy commented on June 29, 2024

Really happy to know! I will keep you posted regarding the ASDK issue and its fix.

from asyncmessagesviewcontroller.

xumeng avatar xumeng commented on June 29, 2024

Thanks, It's helpful!

from asyncmessagesviewcontroller.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.