Comments (4)
What exactly is meant by performance?
I would be wary though of such a broad sweeping statement without establishing context for others first :) Let's be pragmatic.
from until-destroy.
I am sorry I have no further context other than the tweet from the Angular project lead who discourage the usage. I don't have the knowledge to judge whether this applies here or not.
I do agree with being pragmatic. The intend was also to raise a potential issue which wasn't thought about.
from until-destroy.
I've just read attached link to that tweet. Basically, they're unrelated things. V8 team is talking about decorators that can be parsed, compiled and executed at runtime (decorator @myCustomDecorator { ... }
).
I cannot talk about other libraries since I don't know implementations of all decorators provided by some NPM packages π .
But what the UntilDestroy
decorator does is only overrides the onDestroy
property on the directive/component definition, which does the monomorphic property access on the object with the same shape. If we would add a custom property on the definition then yes - it would require the compiler to deoptimize, creat another inline cache and new object shape.
But that's some kind of micro-optimizations that typically even wouldn't be a part of NFRs of some typical application. It's worthing focusing on other things that can improve performance :)
from until-destroy.
Sounds reasonable. I am closing the issue :). Thank you!
from until-destroy.
Related Issues (20)
- unsubscribed checker breaks change detection HOT 1
- Add a util cancel Promises
- Angular 14 ut could not run correctly HOT 1
- Angular 14 ut could not run correctly with a minimal reproducible example
- Angular 14 ut could not run correctly with a a minimal reproducible example HOT 7
- Can I ask what's the utility for this package?
- How to use until-destroy-migration? HOT 4
- NG0204: Token InjectionToken X is missing a Ι΅prov definition after Angular 15 upgrade HOT 20
- Angular 15 Directive Composition API: Cannot access [component] before initialization. HOT 4
- [Documentation] For using `untilDestroyed` in non Angular apps HOT 1
- untilDestroyed assumes ngDevMode is defined HOT 2
- Warnings for github actions builds
- Component is undefined if @UntilDestroy() is used HOT 2
- Supporting other types of Subscriptions HOT 1
- Support TS 5.0 non experimental decorators for the UntilDestroy decorator
- ERROR Error: ASSERTION ERROR: token must be defined [Expected=> null != undefined <=Actual] HOT 5
- Angular 16 takeUntilDestroyed HOT 7
- Need upgrade for Angular 17 HOT 2
- Debugger in source code
- Error when using Target 2022 - Similar issue link provided HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from until-destroy.