Giter Club home page Giter Club logo

Comments (13)

NetanelBasal avatar NetanelBasal commented on June 5, 2024 1

Create a minimal reproducible example, please.

from until-destroy.

ipakhomov avatar ipakhomov commented on June 5, 2024 1

@arturovt that's true.

I faced the described above issue on Angular 9 app, which has Ivy running by default, and enabling AOT has resolved the issue.

from until-destroy.

arturovt avatar arturovt commented on June 5, 2024

@rulamon any progress on this?

from until-destroy.

rulamon avatar rulamon commented on June 5, 2024

@arturovt It's on my todo list, but will probably at the earliest have time for it somewhere in the course of next week.

from until-destroy.

vcanuel avatar vcanuel commented on June 5, 2024

Hi, I have noticed the same issue.
Also, I have noticed that ngxTranslate is unusable in components when using until-destroy in Angular 9 with Ivy. It raises error : The pipe 'translate' could not be found

from until-destroy.

arturovt avatar arturovt commented on June 5, 2024

@vcanuel we are not able to help you without seeing any reproducible example. This is like “shooting a stone” :D

from until-destroy.

vcanuel avatar vcanuel commented on June 5, 2024

@arturovt I understand. I will try to reproduce the error in a simple project.
For now, I have a suspicion that this appears only with lazy loaded routes. Indeed, If I load an other page and go to the previous route (the one that throws an error) it works.

from until-destroy.

rulamon avatar rulamon commented on June 5, 2024

@NetanelBasal
I tried to reproduce this in stackblitz (https://stackblitz.com/edit/until-destroy), but I can't get to actually testing it because I get this error:
Uncaught (in promise): Error: Cannot read property 'onDestroy' of undefined

from until-destroy.

arturovt avatar arturovt commented on June 5, 2024

@rulamon

Because Ivy is not enabled:

Снимок экрана 2020-03-18 в 16 06 47

from until-destroy.

ipakhomov avatar ipakhomov commented on June 5, 2024

@rulamon @vcanuel please check if aot is set to true in your angular.json (path projects["your-project-name"].architect.build.options).

image

from until-destroy.

arturovt avatar arturovt commented on June 5, 2024

@ipakhomov AOT and Ivy are different things and unrelated.

from until-destroy.

rulamon avatar rulamon commented on June 5, 2024

@arturovt
I got it working but I can't reproduce the problem in Stackblitz, even though the issue still occurs in the real app.

from until-destroy.

arturovt avatar arturovt commented on June 5, 2024

Can this be closed? Seems like it's been open since February but no one hasn't provided minimal reproducible example 🙂

from until-destroy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.