Giter Club home page Giter Club logo

Comments (4)

NetanelBasal avatar NetanelBasal commented on May 26, 2024

It's a bit annoying to repeat the hook name with every usage. Maybe we/you can export a react version, something like:

import { untilDestroyed as _untilDestroyed } from '';

export function untilDestroyed(component, name) {
  return _untilDestroyed(component, 'componentWillUnmount');
}

Regarding the package name, it's valid to change the name?

from until-destroy.

TheAifam5 avatar TheAifam5 commented on May 26, 2024

@NetanelBasal
I mean, you can leave the hook name as is.
Hmm, the package name is like associated with Angular ngx but does not use any Angular components, but have Angular's dependencies which IMHO could be removed.

from until-destroy.

NetanelBasal avatar NetanelBasal commented on May 26, 2024

The Angular's dependencies are for dev only.

from until-destroy.

TheAifam5 avatar TheAifam5 commented on May 26, 2024

oops, didn't seen that

from until-destroy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.