Giter Club home page Giter Club logo

Comments (10)

NetanelBasal avatar NetanelBasal commented on June 6, 2024 1

Switched to ng-packger. Everything should be standard now. (v5.2.0)

from until-destroy.

jeffmath avatar jeffmath commented on June 6, 2024

I should mention that I really like the benefits that ngx-take-until-destroy provides, and am thankful that you created it.

from until-destroy.

NetanelBasal avatar NetanelBasal commented on June 6, 2024

5.2.1

from until-destroy.

jeffmath avatar jeffmath commented on June 6, 2024

I get this error now when running an ng build -prod using 5.2.1:

ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in 'C:\Users\Jeff\KBRA\Spectre\spectre-ui\src'
ERROR in Error: Metadata version mismatch for module C:/Users/Jeff/KBRA/Spectre/spectre-ui/node_modules/ngx-take-until-destroy/ngx-take-until-destroy.d.ts, found version 4, expected 3
    at StaticSymbolResolver.getModuleMetadata (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:25616:34)
    at StaticSymbolResolver._createSymbolsOf (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:25404:46)
    at StaticSymbolResolver.getSymbolsOf (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:25385:14)
    at C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:24241:30
    at Array.forEach (<anonymous>)
    at extractProgramSymbols (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:24240:79)
    at AotCompiler.analyzeModulesAsync (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler\bundles\compiler.umd.js:23796:47)
    at CodeGenerator.codegen (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler-cli\src\codegen.js:32:14)
    at Function.NgTools_InternalApi_NG_2.codeGen (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@angular\compiler-cli\src\ngtools_api.js:73:30)
    at _donePromise.Promise.resolve.then (C:\Users\Jeff\KBRA\Spectre\spectre-ui\node_modules\@ngtools\webpack\src\plugin.js:430:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
    at startup (internal/bootstrap/node.js:266:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3)

A non-prod build works fine.

from until-destroy.

jeffmath avatar jeffmath commented on June 6, 2024

Changing the "version" value in ngx-take-until-destroy.metadata.json from 4 to 3 fixes the error in the prod build. I'm not sure if that is the right way to fix it, though.

from until-destroy.

NetanelBasal avatar NetanelBasal commented on June 6, 2024

I can't reproduce this. Can you try delete node modules and re-install it?

from until-destroy.

jeffmath avatar jeffmath commented on June 6, 2024

I tried your suggestion but am still getting the same error for the prod build.

from until-destroy.

NetanelBasal avatar NetanelBasal commented on June 6, 2024

Oh, it's because you are on v5.

from until-destroy.

NetanelBasal avatar NetanelBasal commented on June 6, 2024

Try v5.2.2, please.

from until-destroy.

jeffmath avatar jeffmath commented on June 6, 2024

5.2.2 fixes the problem with the prod build. Thank you!

from until-destroy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.