Giter Club home page Giter Club logo

Comments (5)

aalvarez-stratio avatar aalvarez-stratio commented on June 23, 2024

It would be very nice if we could choose went to apply the decorator functionality. For me, i also need to execute this functionality before my component's ngOnDestroy in some cases.

from until-destroy.

Jpascual55 avatar Jpascual55 commented on June 23, 2024

+1

from until-destroy.

NetanelBasal avatar NetanelBasal commented on June 23, 2024

Is there any case where you would prefer the current behavior?

from until-destroy.

xLama avatar xLama commented on June 23, 2024

Is there any case where you would prefer the current behavior?

I think both behaviors are useful. I use current behavior to exe code before unsuscriptions, like "ngOnUnsuscription", the last chance to do something.

from until-destroy.

arturovt avatar arturovt commented on June 23, 2024

I don't think this somehow brings any benefit for users.

Currently, subscriptions are unsubscribed after the original ngOnDestroy is called. Which means you're capable of doing the reset logic in your ngOnDestroy. You can also do the reset logic in finalize.

What's the benefit then?

from until-destroy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.