createService doesn't accept declarations about spectator HOT 8 CLOSED

Let me do research how people write integration tests in Angular first :-)

from spectator.

Why do you need the router in services? Why not mock it? I'm guessing you aren't testing the router implementation.

from spectator.

I think my problem is mixing unit tests (there you mock Router) and integration tests (there you try to use RouterTestingModule). I use TestBed (and therefore Spectator) for both.

How do you write integration tests?

from spectator.

I don't :). I have no problem adding your suggestion.

from spectator.

In documentation there is only one note about integration tests: https://angular.io/guide/testing#when-would-i-put-specs-in-a-test-folder

I also found an article saying that we should place integration tests in a file with special name *.integration.spec.ts: https://christianlydemann.com/complete-guide-to-angular-testing/

But there is no recommended way how to write them.

If we wanted to avoid mocking and mimicking the whole Router we really need that RouterTestingModule.

Therefore if you dont mind I will create PR which allows declarations also for createService.

from spectator.

No problem.

from spectator.

Tried to prepare test of a service integrating with Router just by listening to router.events but it doesn't emit anything. So I guess RouterTestingModule contains some kind of incomplete mock of Router.

I didn't come up with another case of using declarations array for a service than integration with router so I will close this issue and we can reopen it when another case comes up.

I was also considering a service using a dynamic component from entryComponents but that doesn't related to declarations either.

from spectator.

New issue here: #106

from spectator.