Missing types for query() method about spectator HOT 15 CLOSED

lol, that's precisely what I did right now.

from spectator.

Thank you. Feel free to give more feedback or issues. :)

from spectator.

Isn't it simply just a question of changing Element to R here? https://github.com/NetanelBasal/spectator/blob/master/src/lib/src/internals.ts#L69

from spectator.

In general, you are right. It's a question of what is the more common case? If you most of the times query for DOM element it's more convenient. Don't you think so?

from spectator.

Then perhaps change the return value to HTMLElement instead of Element so common things like .click() work without having to cast the return value?

from spectator.

BTW, Why are you not using the built-in click method?

spectator.click('button');

from spectator.

Because i didn't know that API existed 😁

from spectator.

It will click and trigger change detection for you.

from spectator.

Excellent! Just changed my test to use that API :)

from spectator.

https://netbasal.gitbooks.io/spectator/api.html

from spectator.

I guess we can close this issue then.

from spectator.

I love your idea, but it means that if I changed it, everyone would get the any type. It means that you must pass a type.

spectator.query<HTMLButtonElement>("button");

from spectator.

You could do query<R = Element>(directiveOrSelector: string, options?: { read }): R;

from spectator.

I'm releasing a new version with this change for all queries methods.

from spectator.

Great, thanks!

from spectator.