Support for mark* methods about forms-manager HOT 12 CLOSED

You're welcome to submit a PR.

from forms-manager.

markAllAsTouched() is only available since Angular 8.0.0, so the project would need to be updated to at least this version. So there might be some more changes than just adding the above mentioned methods.

from forms-manager.

You can do it yourself without upgrading anything.

from forms-manager.

You can also add markAllAsDirty.

from forms-manager.

Okay then I'll do it without upgrading it. I'll do a PR as soon as I find some time.

from forms-manager.

I tried to implement the mark* methods but I am struggling a little bit. Maybe I made a mistake somewhere or have a misunderstanding how the library is structured. I have the following problem:

• When using markAllAsTouched() I'll get the error => core.js:4117 ERROR TypeError: this._forEachChild is not a function at Object.push../node_modules/@angular/forms/__ivy_ngcc__/fesm5/forms.js.AbstractControl.markAllAsTouched (forms.js:2951)
• When I use a "normal" method such as markAsDirty() the property of the control does not change.

Can somebody help me out?

My fork

from forms-manager.

You can't call https://github.com/adrianriepl/forms-manager/blob/master/projects/ngneat/forms-manager/src/lib/forms-manager.ts#L261. As you said, it is only available since Angular 8.0.0.

from forms-manager.

You should do something like https://stackoverflow.com/a/44150793/7330592

from forms-manager.

I forked the library after the last commit (where it was changed to Angular 9.1.11) so it should be available already or am I not seeing something?

from forms-manager.

You are right. When do you see the error?

from forms-manager.

You will see the error when you click on the save button in the demo application. Here I call this.manager.markAllAsTouched('stepOne').

https://github.com/adrianriepl/forms-manager/blob/b6751ba9af2569928439316823d9ef758bac9175/src/app/demo/demo.component.ts#L50

from forms-manager.

I'll check it later. But try to debug it. Add a debugger statement and see why you get the error.

from forms-manager.