Giter Club home page Giter Club logo

Comments (13)

Nicoss54 avatar Nicoss54 commented on June 1, 2024 2

@OriginRing @HyperLife1119 @simplejason are you agree with that ? It it's ok i will begin the work :)

from ng-zorro-antd.

Nicoss54 avatar Nicoss54 commented on June 1, 2024 1

Just out of curiosity, won't it have any effect on maintaining older version? Does ng-zorro even continue to support it's older versions?

I don’t totally understand, with this issue I will update the documentation snippet with the new code flow, also i will migrate components on the new code flow.
This will impact the version 17 of ng-zorro. Previous version will not be impacted.
I don’t know If I answer to your curiosity correctly :)

Sorry I was a bit vague, let me explain what I meant in my previous message: Imagine this scenario that ng-zorro supports it's 3 latest versions, that means that currently version number 17 and 16 and 15 needs to be maintained. Normally when a bug is fixed in version 17, it is cherry-picked via git to branches /16.x and /15.x.

Now my question is that whatever ng zorro supports several versions or just it's latest version. Because if it supports several versions, maybe it's not a good idea to move to new code flow now, because it will make automatic cherry-pick not possible, and whenever a bug is fixed it should be manually cherry-picked which can be very time consuming.

Normally we support only the current version, if @OriginRing can confirm this it will be great. But This issue is just an update doc issue, I will just ypdate the snippet code of component documentation not the component business logic

from ng-zorro-antd.

Nicoss54 avatar Nicoss54 commented on June 1, 2024 1

Would you mind if I join you on these tasks? @Nicoss54

@ParsaArvanehPA its should be nice to work together on this, unfortunately it will be complicated, and it will be a high risk of doing the same work or have conflicts :/

from ng-zorro-antd.

HyperLife1119 avatar HyperLife1119 commented on June 1, 2024

I agree with this suggestion!

from ng-zorro-antd.

Nicoss54 avatar Nicoss54 commented on June 1, 2024

I agree with this suggestion!

I take the point

from ng-zorro-antd.

ParsaArvanehPA avatar ParsaArvanehPA commented on June 1, 2024

Just out of curiosity, won't it have any effect on maintaining older version?
Does ng-zorro even continue to support it's older versions?

from ng-zorro-antd.

Nicoss54 avatar Nicoss54 commented on June 1, 2024

Just out of curiosity, won't it have any effect on maintaining older version? Does ng-zorro even continue to support it's older versions?

I don’t totally understand, with this issue I will update the documentation snippet with the new code flow, also i will migrate components on the new code flow.

This will impact the version 17 of ng-zorro. Previous version will not be impacted.

I don’t know If I answer to your curiosity correctly :)

from ng-zorro-antd.

ParsaArvanehPA avatar ParsaArvanehPA commented on June 1, 2024

Just out of curiosity, won't it have any effect on maintaining older version? Does ng-zorro even continue to support it's older versions?

I don’t totally understand, with this issue I will update the documentation snippet with the new code flow, also i will migrate components on the new code flow.

This will impact the version 17 of ng-zorro. Previous version will not be impacted.

I don’t know If I answer to your curiosity correctly :)

Sorry I was a bit vague, let me explain what I meant in my previous message:
Imagine this scenario that ng-zorro supports it's 3 latest versions, that means that currently version number 17 and 16 and 15 needs to be maintained.
Normally when a bug is fixed in version 17, it is cherry-picked via git to branches /16.x and /15.x.

Now my question is that whatever ng zorro supports several versions or just it's latest version.
Because if it supports several versions, maybe it's not a good idea to move to new code flow now, because it will make automatic cherry-pick not possible, and whenever a bug is fixed it should be manually cherry-picked which can be very time consuming.

from ng-zorro-antd.

ParsaArvanehPA avatar ParsaArvanehPA commented on June 1, 2024

Just out of curiosity, won't it have any effect on maintaining older version? Does ng-zorro even continue to support it's older versions?

I don’t totally understand, with this issue I will update the documentation snippet with the new code flow, also i will migrate components on the new code flow.
This will impact the version 17 of ng-zorro. Previous version will not be impacted.
I don’t know If I answer to your curiosity correctly :)

Sorry I was a bit vague, let me explain what I meant in my previous message: Imagine this scenario that ng-zorro supports it's 3 latest versions, that means that currently version number 17 and 16 and 15 needs to be maintained. Normally when a bug is fixed in version 17, it is cherry-picked via git to branches /16.x and /15.x.
Now my question is that whatever ng zorro supports several versions or just it's latest version. Because if it supports several versions, maybe it's not a good idea to move to new code flow now, because it will make automatic cherry-pick not possible, and whenever a bug is fixed it should be manually cherry-picked which can be very time consuming.

Normally we support only the current version, if @OriginRing can confirm this it will be great. But This issue is just an update doc issue, I will just ypdate the snippet code of component documentation not the component business logic

Oh my bad, I thought you were talking about changing the component's business logic :)

from ng-zorro-antd.

ParsaArvanehPA avatar ParsaArvanehPA commented on June 1, 2024

More about the ng-zorro support, as mentioned here a lot of future changes may depend on knowing the answer to as how many prior released versions should be maintained.

If we want to follow Angular on LTS support, we should support the releases made in the last 18 months: Angular LTS support
For environment support we currently follow their policy

from ng-zorro-antd.

Nicoss54 avatar Nicoss54 commented on June 1, 2024

More about the ng-zorro support, as mentioned here a lot of future changes may depend on knowing the answer to as how many prior released versions should be maintained.

If we want to follow Angular on LTS support, we should support the releases made in the last 18 months: Angular LTS support For environment support we currently follow their policy

If i'm not wrong we don't support the previous version of Ng-Zorro but i'm not sure about that. If @OriginRing or @simplejason can confirm or not this supposition it will be great.

But this issue is just for snippet exemple code so no problems currently

from ng-zorro-antd.

OriginRing avatar OriginRing commented on June 1, 2024

@Nicoss54 The previous version will not be maintained with out major errors, so you can start working on the replacement.

super, first PR done for auto complete :)

from ng-zorro-antd.

ParsaArvanehPA avatar ParsaArvanehPA commented on June 1, 2024

Would you mind if I join you on these tasks? @Nicoss54

from ng-zorro-antd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.