[Bug] Navigation links do not work when using baseHref about ng-doc HOT 10 CLOSED

Looks good. Thank you!

from ng-doc.

Good catch thanks! I'll fix it right now

from ng-doc.

🎉 This issue has been resolved in version 15.7.10 🎉

The release is available on:

• v15.7.10
• GitHub release

Your semantic-release bot 📦🚀

from ng-doc.

Thanks for the quick fix, but I think using replace() here is not a good idea because my API scope is also the same string as my baseHref, so this breaks links to API pages.

from ng-doc.

And even if I change the API scope name, links generated from markdown (e.g. to API pages) do not work when opening them in a new tab

from ng-doc.

Ah I see, ok let me think about a better solution maybe I will be able to prepare HTML and update href attributes on the builder side

from ng-doc.

I found a solution that I had considered during development but decided against because I thought it was unnecessary. However, now I see that it is necessary.

The problem was that although the handler used Angular Router, when hovering over a link, an incorrect address was still displayed because the actual address in the href attribute was not changing. It was only modified when attempting to navigate to the link.

I removed the code in NgDocRootComponent that handled link clicks, which sometimes intercepted clicks on links created using routerLink, leading to unexpected consequences if the URL was not properly processed, or if clicks on links in the demo were being handled when they shouldn't be.

I could have modified these links on the builder side, but that wouldn't have solved the problem of click handling in NgDocRootComponent.

Solution:
NgDoc has a mechanism for processors, which I use to convert certain HTML elements created using innerHTML into Angular components. Therefore, I added a new processor for links that wraps each link on the page in NgDocPageLinkComponent.

NgDocPageLinkComponent uses the routerLink directive, which you know modifies the link passed to it by adding baseHref, so everything should work natively through Angular Router without creating problems with baseHref.

from ng-doc.

🎉 This issue has been resolved in version 15.7.11 🎉

The release is available on:

• v15.7.11
• GitHub release

Your semantic-release bot 📦🚀

from ng-doc.

Sry, I added another fix, I forgot about links in code examples and demos that are generated based on keywords

from ng-doc.

🎉 This issue has been resolved in version 15.7.12 🎉

The release is available on:

• v15.7.12
• GitHub release

Your semantic-release bot 📦🚀

from ng-doc.