Giter Club home page Giter Club logo

Comments (7)

jnizet avatar jnizet commented on June 20, 2024 3

I would first try to be zoneless and then try to move to signals, for the following reasons:

  • zoneless support should be possible without moving to signals, with a smaller effort
  • moving to signals is a harder task, maybe necessitating breaking changes in the API, and would rely on features that are not stable yet (effect, toSignal, toObservable)

from ng-bootstrap.

jnizet avatar jnizet commented on June 20, 2024 1

Zoneless could probably be achieved by keeping the code as is, but there are usages of NgZone (onStable) that need to be replaced. I started it try doing it by replacing them by afterRender or afterNextRender, but there are places where it's quite hard.

But I agree that, for the long term, using signals where it makes sense would be a good idea.

from ng-bootstrap.

sysmat avatar sysmat commented on June 20, 2024 1

@bastienmoulia as others are saying, signals are not required for zonless

from ng-bootstrap.

sysmat avatar sysmat commented on June 20, 2024
  • when using ng 18: provideExperimentalZonelessChangeDetection and NgbModal.open(myComponent) is not working
  • in dom I see element, but not rendered propery
  • the same problem with Toast
  • the same problem with Tooltip

from ng-bootstrap.

maxokorokov avatar maxokorokov commented on June 20, 2024

Please open separate issues for zoneless support with concrete failures.
I think we should release a major first with Angular 18 support and then add zoneless in a feature release, WDYT?

from ng-bootstrap.

bastienmoulia avatar bastienmoulia commented on June 20, 2024

Please open separate issues for zoneless support with concrete failures.

I think we should release a major first with Angular 18 support and then add zoneless in a feature release, WDYT?

Sure thing, first Angular 18, then we can add signal everywhere, and then activate zoneless!

from ng-bootstrap.

maxokorokov avatar maxokorokov commented on June 20, 2024

Indeed, I wasn't talking about signals at all in my comment, it should be last for me too for sure.

from ng-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.