[ngbTypeahead] selectOnExact results length condition about ng-bootstrap HOT 4 OPEN

Sounds good ! let's have first-match... i'll open the PR asap

from ng-bootstrap.

We could fix this by allowing you to choose the strategy, like the Router does with pathMatch?: 'prefix' | 'full' → https://angular.dev/api/router/Route

Something like:

1. @Input() selectOnExact: boolean | 'prefix'; → I don't think naming is great though
2. new @Input() selectOnMatch: 'prefix' | 'full'; → might need a breaking change deprecation of selectOnExact later to avoid having both

Any suggestions from your side, maybe?

from ng-bootstrap.

We could fix this by allowing you to choose the strategy, like the Router does with pathMatch?: 'prefix' | 'full' → https://angular.dev/api/router/Route

Something like:

1. @Input() selectOnExact: boolean | 'prefix'; → I don't think naming is great though
2. new @Input() selectOnMatch: 'prefix' | 'full'; → might need a breaking change deprecation of selectOnExact later to avoid having both

Any suggestions from your side, maybe?

Hi @maxokorokov, thanks for your feedback.
I like the first solution you propose, probably using 'first_match' instead of 'prefix'... we'll end up having :

@Input() selectOnExact: boolean | 'first_match';

which is retrocompatible and idiomatic as well.

from ng-bootstrap.

Sure, works for me (apart from first-match, not first_match) :)
Shouldn't be hard to do either and non-breaking change.

You could open a PR if you're up for it (can inspire from the original #4421 for the selectOnExact)

from ng-bootstrap.