Comments (3)
Do we need to import the original? Is it not possible to provide an abstract class or interface?
from ng-bootstrap.
Or maybe one idea is to provide a dummy class with methods as DatepickerEngine and force users to extend it and provide that.
from ng-bootstrap.
Downside is that if the user don't use it, app won't work, but I think that is a convention in angular 2.
I think that we can easily avoid this issue by sth like:
class NgbDatePicker {
constructor(@Optional() private _settings: DatepickerEngine = new DefaultDatepickerEngine()) {
}
}
This way people will get defaults if they don't provide anything.
Also, I think that if there are 2 providers under the same token they will override each other (the last one wins). So we could export NGB_PROVIDERS or NGB_DATEPICKER_PROVIDERS with defaults.
I think we can close this now as the general idea here is good and we can figure out technical details (if there is anything left to figure out) when actually working on the implementation.
from ng-bootstrap.
Related Issues (20)
- ngbAccordionToggle is not disabled when ngbAccordionItem is disabled
- ngbDropdown inside ngbNavLink causes error
- Feature request: expose componentRef in NgbModalRef HOT 1
- ngbAccordionCollapse does not collapse when ngbAccordionItem is disabled
- Accordion directive ignores Input Id
- Offcanvas is not dismissed, starts to stack HOT 1
- i am facing issue when i build the angular application HOT 2
- accordion prevent close (or open) of a item.
- Tooltip preventOverflow option HOT 2
- DatePICKER ISSUE OR BUG HOT 4
- Popover autoClose not dynamic HOT 4
- Users using a keyboard are unable to scroll down the modal when opened using arrow keys.
- ngb-offcanvas: container option not working HOT 5
- NgbDropdown using autoClose in template and dynamically changing it does not work HOT 4
- adding ngbNavLink cause all subsequent elements to be invisible HOT 1
- NgbDatePicker does not follow Internationalization format for firstDayOfWeek HOT 2
- Huge Bundle Size when import every module HOT 7
- NgbOffcanvasRef and NgbModalRef should expose a ComponentRef HOT 3
- close() should not trigger openChange, if invoked from ngOnDestroy
- ERROR NullInjectorError: R3InjectorError(AppModule)[NgbDropdown -> NgbDropdown]: NullInjectorError: No provider for NgbDropdown HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ng-bootstrap.