Giter Club home page Giter Club logo

Comments (3)

wesleycho avatar wesleycho commented on May 20, 2024

Do we need to import the original? Is it not possible to provide an abstract class or interface?

from ng-bootstrap.

wesleycho avatar wesleycho commented on May 20, 2024

Or maybe one idea is to provide a dummy class with methods as DatepickerEngine and force users to extend it and provide that.

from ng-bootstrap.

pkozlowski-opensource avatar pkozlowski-opensource commented on May 20, 2024

Downside is that if the user don't use it, app won't work, but I think that is a convention in angular 2.

I think that we can easily avoid this issue by sth like:

class NgbDatePicker {
    constructor(@Optional() private _settings: DatepickerEngine = new DefaultDatepickerEngine()) {
    }
}

This way people will get defaults if they don't provide anything.

Also, I think that if there are 2 providers under the same token they will override each other (the last one wins). So we could export NGB_PROVIDERS or NGB_DATEPICKER_PROVIDERS with defaults.

I think we can close this now as the general idea here is good and we can figure out technical details (if there is anything left to figure out) when actually working on the implementation.

from ng-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.