Giter Club home page Giter Club logo

Comments (4)

ffilz avatar ffilz commented on June 18, 2024 1

This will require a re-submit when we are ready to merge it. We're not quite ready, but soon...

from nfs-ganesha.

ffilz avatar ffilz commented on June 18, 2024

Push a patch to gerrithub and let's talk.

from nfs-ganesha.

liorsu avatar liorsu commented on June 18, 2024

I uploaded the commits for that for review- https://review.gerrithub.io/q/topic:clang-format

Note that for the commit- https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1187343, checkpatch has many warnings and errors
Most are false positive and I saw discussions for (for example not recognizing a pointer correctly and mistaking it to be a multiplication operator that requires spaces around it).

I added a commit that changes the pre-commit hooks to verify the clang-format.
Clang-format has integration with many IDEs so developers can configure their IDE to use clang-format to automatically format their code without dealing with formatting at all.

We can also add to gerrit a clang-format verifier instead of the existing checkpath.

If that will be accepted I'll also update the documentation regarding clang-format instead of checkpatch.pl.

from nfs-ganesha.

xiaods avatar xiaods commented on June 18, 2024

I uploaded the commits for that for review- https://review.gerrithub.io/q/topic:clang-format

Note that for the commit- https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1187343, checkpatch has many warnings and errors Most are false positive and I saw discussions for (for example not recognizing a pointer correctly and mistaking it to be a multiplication operator that requires spaces around it).

I added a commit that changes the pre-commit hooks to verify the clang-format. Clang-format has integration with many IDEs so developers can configure their IDE to use clang-format to automatically format their code without dealing with formatting at all.

We can also add to gerrit a clang-format verifier instead of the existing checkpath.

If that will be accepted I'll also update the documentation regarding clang-format instead of checkpatch.pl.

please resolve the conflict files on gerrit.

from nfs-ganesha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.