Comments (4)
This will require a re-submit when we are ready to merge it. We're not quite ready, but soon...
from nfs-ganesha.
Push a patch to gerrithub and let's talk.
from nfs-ganesha.
I uploaded the commits for that for review- https://review.gerrithub.io/q/topic:clang-format
Note that for the commit- https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1187343, checkpatch has many warnings and errors
Most are false positive and I saw discussions for (for example not recognizing a pointer correctly and mistaking it to be a multiplication operator that requires spaces around it).
I added a commit that changes the pre-commit hooks to verify the clang-format.
Clang-format has integration with many IDEs so developers can configure their IDE to use clang-format to automatically format their code without dealing with formatting at all.
We can also add to gerrit a clang-format verifier instead of the existing checkpath.
If that will be accepted I'll also update the documentation regarding clang-format instead of checkpatch.pl.
from nfs-ganesha.
I uploaded the commits for that for review- https://review.gerrithub.io/q/topic:clang-format
Note that for the commit- https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1187343, checkpatch has many warnings and errors Most are false positive and I saw discussions for (for example not recognizing a pointer correctly and mistaking it to be a multiplication operator that requires spaces around it).
I added a commit that changes the pre-commit hooks to verify the clang-format. Clang-format has integration with many IDEs so developers can configure their IDE to use clang-format to automatically format their code without dealing with formatting at all.
We can also add to gerrit a clang-format verifier instead of the existing checkpath.
If that will be accepted I'll also update the documentation regarding clang-format instead of checkpatch.pl.
please resolve the conflict files on gerrit.
from nfs-ganesha.
Related Issues (20)
- [Question] How should `owner` parameter be used in lock_op2() in FSAL api? HOT 6
- possible lock starvation in lock conflict scenerio HOT 2
- Add testing instructions to CONTRIBUTING_HOWTO.txt HOT 1
- Using the DBUS to dynamically update protocols of export, changed from 3 to 3, 4, not in effect. HOT 15
- Ha cluster config HOT 1
- [Question] How does nfs-ganesha avoid state reclaimed in edge conditions? HOT 13
- [Question] Is there replay cache for NFS v3 or NFS v4.0 in nfs-ganesha? HOT 2
- Unable to git clone on top of NFS share with Ganesha v6. HOT 2
- How to close socket when socket idle ? HOT 4
- NFSv4 ACL support in FSAL_VFS but without VFS_POSIX_ACL / USE_ACL_MAPPING HOT 8
- 5.7: build fails with `USE_GTEST=ON` HOT 1
- Potential bug: lost export_ops->unexport() if export_ops->lookup_path() fails HOT 2
- ganesha crash in Protocols/NFS/nfs3_create.c HOT 3
- ganesha crash while deleting lock_entry->sle_list in 4.3 HOT 3
- v5.7 packages for SLES15 ? HOT 1
- 5.9: FileNotFoundError: [Errno 2] No such file or directory: 'dist/ganesha-top-5.9-py3-none-any.whl' HOT 4
- ganesha thread is stuck HOT 9
- NFS3/NFS4 -> NFS3 proxy listdir not working HOT 2
- Ha cluster config v2 HOT 10
- Cannot create new virtual disks in ESXi 6.7, 7 or 8 on a Datastore served over NFS from CephFS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nfs-ganesha.