Charset troubles about node-unblocker HOT 5 CLOSED

Can you give me an example where this causes trouble?

The first change shouldn't have any effect because of how iconv.encodingExists handles undefined:

iconv.encodingExists(undefined);
//> false

and the else if block is mainly used for when we need to scan through the HTML looking for a <meta charset=... tag. That's usually because charset == undefined, so in that case, adding charset && to the if would break it.

But, that said, this stuff is tricky and I wouldn't be surprised if there is a bug in there somewhere. If you can give me a unit test or URL where things fail, that would be very helpful.

from node-unblocker.

Trouble on page - https://2ip.ru/ when try to load data from this URL (method POST) -
https://2ip.ru/?area=ajaxIspRatingListViewer

from node-unblocker.

Ok, I figured it out and added a test for it - the code that was supposed to find the <meta charset... tag had a bug where if it never saw a <meta... or </head> tag, it would buffer indefinitely instead of just passing the data along.

But now another test is failing on the CI (but passing on my laptop), so I've got some more debugging to do...

from node-unblocker.

Fixed (the test infrastructure I was using got more strict in a minor release, and the old version on my laptop passed, but the current version that travis ci installed didn't...)

Version 1.0.8 released, please try it out and let me know if it works for you.

from node-unblocker.

Now all ok)
Thanks!

from node-unblocker.