Comments (9)
Good catch, do think you can fix it?
On Apr 23, 2014 8:11 AM, "Emil Hemdal" [email protected] wrote:
I created a test for this with PHP:
http://dev.ldbib.se/test/cookie_proxive_test.php
should redirect to
http://dev.ldbib.se/test/cookie_proxive_test2.php
and set a cookie named "hello" to "world"Sourcecode to the tests:
http://dev.ldbib.se/test/cookie_proxive_test.txt
http://dev.ldbib.se/test/cookie_proxive_test2.txt—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30
.
from node-unblocker.
Working on it.
from node-unblocker.
I might have a working solution. I will test it further tomorrow.
from node-unblocker.
Cool, thanks!
On Thu, Apr 24, 2014 at 9:12 AM, Emil Hemdal [email protected]:
I might have a working solution. I will test it further tomorrow.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-41277809
.
Nathan Friedly
Minister, JavaScript Ninjaneer
http://nfriedly.com
from node-unblocker.
See #31
from node-unblocker.
from node-unblocker.
Hey, thanks, this is pretty close to perfect. We do need to make one change for your default cookie path though: it should default to the current directory, not /.
For example, a cookie set on /foo/bar.html should get a path of /foo/ if it's not specified in the set-cookie header.
See more info at http://tools.ietf.org/html/rfc2109#section-4.3.1
Also, you can make changes to your code after sending a pull request and they will still get included - a pull request just points to a branch, and I get the latest code in that branch whenever I merge it ;)
from node-unblocker.
@nfriedly,
I just had a look at it, and I think @emilhem latest PR (#32) actually does that.
https://github.com/emilhem/node-unblocker/blob/patch-2/lib/cookies.js#L108-111
if no path is present it defaults to: the pathname trimmed to the last slash
from node-unblocker.
Oh, right.. I forgot about that, thanks. I'll merge it in right now.
from node-unblocker.
Related Issues (20)
- [Bug] Does Not work. HOT 10
- Weird Redirect when deploying with openode.io HOT 2
- Error HOT 1
- Discord isn't working. HOT 5
- Discord link HOT 2
- Next.js support HOT 3
- maleik2
- JustAguy HOT 1
- In Search Of A Proxy HOT 2
- Setting a static URL without typing it after the prefix HOT 7
- Google safe-browsing flags unblocker as phishing
- Proxy not working with Nike.com and Cloudflare HOT 2
- My administrator's website still blocks it even when I use unblockernode
- Z_DATA_ERROR HOT 7
- use node-unblocker in client sveltekit without node js HOT 1
- how to use node-unblocker with https-proxy-agent HOT 1
- sometime error and stuck when use in docker HOT 3
- https://www.youtube.com/embed/XGxIE1hr0w4 --This type of URL cannot be proxied HOT 8
- URL PATH - [feature] HOT 6
- how to add ads in unblocked website HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-unblocker.