contacts not downloadable about vm HOT 5 CLOSED

I found some more errors in nextcloud-install-production.sh

1. Home-dir from ncadmin

   root@nctest3:~# cd ../ncadmin
   root@nctest3:/home/ncadmin# ll
   insgesamt 20
   drwxr-xr-x 2 ncadmin ncadmin 4096 Okt 11 20:12 ./
   drwxr-xr-x 4 root root 4096 Okt 11 20:04 ../
   -rw-r--r-- 1 ncadmin ncadmin 220 Okt 11 20:04 .bash_logout
   -rw-r--r-- 1 root root 829 Okt 11 20:12 .bash_profile
   -rw-r--r-- 1 ncadmin ncadmin 3771 Okt 11 20:04 .bashrc

owner of .bash_profile should be ncadmin:ncadmin

1. wrong path in .bash_profile

root@nctest3:/home/ncadmin# cat .bash_profile
# ~/.profile: executed by the command interpreter for login shells.
# This file is not read by bash(1), if ~/.bash_profile or ~/.bash_login
# exists.
# see /usr/share/doc/bash/examples/startup-files for examples.
# the files are located in the bash-doc package.
# the default umask is set in /etc/profile; for setting the umask
# for ssh logins, install and configure the libpam-umask package.
#umask 022
# if running bash
if [ -n "4.3.46(1)-release" ]
then
# include .bashrc if it exists
if [ -f "/root/.bashrc" ]
then
. "/root/.bashrc"
fi
fi
# set PATH so it includes user's private bin if it exists
if [ -d "/root/bin" ]
then
PATH="/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/snap/bin"
fi
bash /var/scripts/instruction.sh
bash /var/scripts/history.sh
sudo -i

• ncadmin has no possibility to test "/root/.bashrc"
• private bin is ~/bin or /home/ncadmin/bin not /root/bin

this will happen, because of using the HOME Variable in the script change-ncadmin-profile.sh
--> you do it as root!

better: "~/.bashrc"  and  "~/bin"

from vm.

Yes, that's a known issue and is happening becuase we fetch the version number from the XML file in the contacts repo. The XML file says that it's 1.5.0.0 but the version is 1.4.0.0. I have pointed this out to the contact devs, and I'm hoping that this will not happen in future versions.

Regarding the .bash_profile, I'll have a look and change it in future versions.

Thanks for your report! Keep 'em coming. :)

from vm.

@eplusk can you please test the PR I've created?

from vm.

@enoch85 Ihave tested the PR, you have to change
$UNIXUSER-PROFILE to $UNIXUSER_PROFILE
then it is ok.
Minus or Underscore is hard to detect

from vm.

@eplusk Thanks! Please give your 👍 in the PR before I merge, thanks!

from vm.