Giter Club home page Giter Club logo

Comments (28)

newhinton avatar newhinton commented on August 30, 2024 10

I am currently working on an update for Splash. I already fixed the bug you found, but there is still a bit more to do. I hope to be done before christmas!

from unsplash.

newhinton avatar newhinton commented on August 30, 2024 7

I am infact working on support for 28. I have fixed most issues with the latest version, but i still have to test some new features. I couldnt spare much time for this project, so progress has been slow.

from unsplash.

ste7enm avatar ste7enm commented on August 30, 2024 1

Not related @Raemsna. Issue is settings page does not work.

Perhaps related to this and the fix, I'm in NextCloud 28.0.1 and have enabled Splash. It works, but no modifications made in the settings (under Theming) save. It claims that it's saved, but then you refresh and everything has reset to default settings. Other changes made under Theming to non-Splash settings are saved correctly.

Changes
Changes made and saved.
Refresh
Settings after refreshing page.

Edit: Just to add a bit more colour in case it's related and useful:
Log

from unsplash.

BenH4 avatar BenH4 commented on August 30, 2024 1

Not related @Raemsna. Issue is settings page does not work.

Perhaps related to this and the fix, I'm in NextCloud 28.0.1 and have enabled Splash. It works, but no modifications made in the settings (under Theming) save. It claims that it's saved, but then you refresh and everything has reset to default settings. Other changes made under Theming to non-Splash settings are saved correctly.

Changes Changes made and saved. Refresh Settings after refreshing page.

Edit: Just to add a bit more colour in case it's related and useful: Log

I am having the same issue on a fresh install of NC

from unsplash.

BenH4 avatar BenH4 commented on August 30, 2024 1

This is by no means a fix, but will make it so that "Set random image as dashboard background" is on by default and should get the dashboard background working on 28.01.

cd nextcloud/custom_apps/unsplash/lib/Services
sudo nano SettingsService.php

change line: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 0) == 1; to: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 1) == 1;

Did the trick, not a fix indeed but thanks!!!

from unsplash.

Raemsna avatar Raemsna commented on August 30, 2024

maybe related to #123 ?

from unsplash.

TakeshiTurk avatar TakeshiTurk commented on August 30, 2024

Not related @Raemsna. Issue is settings page does not work.

resim

from unsplash.

ChildLearningClub avatar ChildLearningClub commented on August 30, 2024

This is by no means a fix, but will make it so that "Set random image as dashboard background" is on by default and should get the dashboard background working on 28.01.

cd nextcloud/custom_apps/unsplash/lib/Services
sudo nano SettingsService.php

change line:
return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 0) == 1;
to:
return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 1) == 1;

from unsplash.

jet438 avatar jet438 commented on August 30, 2024

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

from unsplash.

SK-Crow avatar SK-Crow commented on August 30, 2024

Noting that @ste7enm is correct with one of the issues on Hub 28, I'm getting the same error message in my logs. Just commenting ot keep an eye on it.

from unsplash.

ste7enm avatar ste7enm commented on August 30, 2024

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

I'll mention too that it does work in NC28 (in that you do get random images from Unsplash displayed as background images, as intended), it's just that you can't make changes to your settings (at least for me). So if you're cool with keywords "nature,nature" and not making any other tweaks, you could still update @jet438.

from unsplash.

SK-Crow avatar SK-Crow commented on August 30, 2024

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

I'll mention too that it does work in NC28 (in that you do get random images from Unsplash displayed as background images, as intended), it's just that you can't make changes to your settings (at least for me). So if you're cool with keywords "nature,nature" and not making any other tweaks, you could still update @jet438.

I found that it doesn't function at all. It doesn't break anything on my end, but both saving and splash login are not functioning. It's like it's not there at all. Just errors.

image
image
image

from unsplash.

ste7enm avatar ste7enm commented on August 30, 2024

I found that it doesn't function at all. It doesn't break anything on my end, but both saving and splash login are not functioning. It's like it's not there at all. Just errors.

You're right, if you're logged out, you get the default clouds. As soon as I log in though, I get nature images. 🤷‍♂️

from unsplash.

ingsocdev avatar ingsocdev commented on August 30, 2024

Hopefully this is still in progress 🤞 I really want to use this with NC 28. Nothing works right now for me with this.

from unsplash.

newhinton avatar newhinton commented on August 30, 2024

Hopefully this is still in progress 🤞 I really want to use this with NC 28. Nothing works right now for me with this.

Yes! I finally figured out why the images weren't loading anymore on the login-screens. Now i only have to add a small attribution-icon to the login-pages, and i should be good to go!

from unsplash.

newhinton avatar newhinton commented on August 30, 2024

If you are willing, #133 contains an updated version of splash. It should work with 28, and it also provides a few bug fixes AND features, like image-caching and source attribution on the loginscreen!

image

It is currently in testing, so there might be bugs.

from unsplash.

ingsocdev avatar ingsocdev commented on August 30, 2024

Let me see if I can give this version a try!

from unsplash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.