Comments (7)
Why is it important to have it integrated into the viewer? I understand that we get the sidebar for free which is nice.
We also aimed to have a more standardized way for apps to show file content. Before the viewer, each app needed to handle the overlay, styling and edgecases themselves, so just integrating in the viewer makes it a lot easier to maintain and the overall experience more consistent.
But on the other hand we loose the header bar which can be useful to navigate around, see other people in the same document, search, setting, ...
I agree that the header bar is useful here. Maybe we can have some different styling in the viewer for editing files, which could also be used by collabora/other file editors. Showing the header is something that is pretty straight forward with some basic styles:
cc @skjnldsv
from text.
All fixed already, thanks @skjnldsv
from text.
May I ask a stupid question? Why is it important to have it integrated into the viewer? I understand that we get the sidebar for free which is nice. But on the other hand we loose the header bar which can be useful to navigate around, see other people in the same document, search, setting, ...
from text.
I agree that the header bar is useful here. Maybe we can have some different styling in the viewer for editing files, which could also be used by collabora/other file editors. Showing the header is something that is pretty straight forward with some basic styles:
Agree, but the nextcloud header bar should not be used for apps-customisations (like richdocuments for example)
This is confusing as the header is the same across all apps, so it's not really where the user should expect to find apps-related informations I'd say.
We can add the informations we want into the viewer header, which is already where we have infos, so it is better in a UX point of view. cc @jancborchardt
But on the other hand we loose the header bar which can be useful to navigate around, see other people in the same document, search, setting, ...
Well, if you click anything in the header, you'll quit the collaborative editing anyway as it will change the page. So I'd rather have the user make sure to quite the text app and navigate away than thinking it will not lose its current editing session and go into another app/setting section :)
from text.
- Keyboard events should be disabled (arrow, enter should only be catched by the editor, not the viewer)
- Expose the file id to the viewer component
- Overwrite max-width for mobile view, so that the editor is shown full size on small screens
- We probably don't need navigation between documents with the arrows
- Slideshow doesn't make sense for documents
So basically, aside from the fileid prop, we should just add a config to force an independant view? I'd say, if the dev do not provide a group
property, then handle it as a standalone view? What do you think?
It would then not fetch the nearby similar files. Arrows will automatically be disabled and slideshow as well (already in the viewer), as well as keys binding :)
from text.
So basically, aside from the fileid prop, we should just add a config to force an independant view? I'd say, if the dev do not provide a group property, then handle it as a standalone view? What do you think?
It would then not fetch the nearby similar files. Arrows will automatically be disabled and slideshow as well (already in the viewer), as well as keys binding :)
Yes, I had the same in mind. 👍
from text.
Closed by nextcloud/viewer#79
from text.
Related Issues (20)
- Open text documents with lazy session initialization
- Further improve copy and paste behavior HOT 1
- Clarify relationship between link text and url HOT 3
- [stable28] Copied version number inside multiple paragraphs is escaped.
- Mention circle in markdown documents HOT 1
- No folder description in Favorites from 28 on
- Translated readme title escaped after creating the file
- Editing in code block does not work in firefox
- NotFoundException
- Detect inconsistent initial steps in yjs and require page reload
- Hovering over a link no longer shows the native link preview in the browser
- Close has already been called on the connection
- Markdown standard links. HOT 2
- Deleting a line is impossible HOT 1
- Content lost after file renaming from .md to .txt HOT 3
- Table cells containing repeated newlines get garbled HOT 3
- Ctrl+A inside table should only select all of the cells content instead of the whole document.
- Cannot use dropdown menus in translate popup in Text HOT 2
- [Bug]: "Editing session has expired. Please reload the page." on public share links with readme.md HOT 1
- Markdown files with attachments cannot be edited locally
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from text.