Giter Club home page Giter Club logo

Comments (3)

rullzer avatar rullzer commented on May 24, 2024 1

mmmm I get your point @nickvergessen. Having yet another endpoint would hugely duplicate the code.

Possibility would be to filter based on the itemType indeed.

However, keep in mind that we search based share type. So the sharees have to properly fall into that category.

from spreed.

nickvergessen avatar nickvergessen commented on May 24, 2024

@schiessle @rullzer I wonder if https://github.com/nextcloud/server/blob/6e52091c8e344cf0ea83ab44f79c550f139bb6ac/apps/files_sharing/lib/Controller/ShareesAPIController.php#L434-L436 should be registered also based on the itemType, so e.g. this spreed app can return users independent from the share manager.

I like the idea of having one endpoint for all these requests, but on the other hand it already starts getting messy a bit. Any though?

from spreed.

nickvergessen avatar nickvergessen commented on May 24, 2024

Server was merged, groups are displayed and the current user is skipped => closing

from spreed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.