Comments (14)
So, thinking about this it seems that uniformity with the other apps is more important than the value of experimenting with a new position for the search.
That’s a separate topic though still. With other considerations like accessibility on mobile – if it’s in the top of the sidebar, searching will be difficult to access and require a two-step process, if it’s discovered at all. Unlike the top right spot which people are used to from Android and also iOS to a certain extent.
So @Henni if you agree then the sensible solution might be to use the normal search field position after all.
from notes.
@jancborchardt @camilasan and i discussed this topic again in a design review at the hackweek and we came to the conclusion that even if it is technically filtering and not searching (what i do not aggree), the input should be on the top right position.
from notes.
@stefan-niedermann I'll introduce a new standard for the search button soon :)
from notes.
it filters the list of articles matching the search pattern in note title as well as body.
I would expect that most users would think of this as "Search" and thus look for it with the traditional search icon and UI location, as the original poster did on this issue.
from notes.
@jancborchardt Actually, there is already a standard for the search, so it might fit the needs of the notes app already :)
The lack of documentation is unfortunate though :/
The only work will be to make the standard 'standardized' enough so our new vue apps can work with it
from notes.
Look at the JavaScript file that handle the search in server!
https://github.com/nextcloud/server/blob/master/core/search/js/search.js
Lots of comments it seems ;)
from notes.
Hi @stefan-niedermann,
look at the "search function" as a filter: it filters the list of articles matching the search pattern in note title as well as body. Thus that's the correct place.
We might discuss, if the glass icon is the best icon for this job (=field). I would prefer a funnel. And one could argue, that the input field is somewhat hidden thanks to the "flat" design. A really visible input field might be better/more helpful. But the place is correct (IMHO).
from notes.
@jancborchardt would love to have your feedback on this, as we talked about this a while ago.
from notes.
..and even if we provide full-text search later, the main use-case is finding the right note.
from notes.
@skjnldsv anything we could implement here already? :)
Or could we fix it even without that new standard @nextcloud/notes?
from notes.
@skjnldsv as this app is still in Angular, it would be awesome to get some pointers on how to use the standard way of searching in the Notes app for the time being. :)
from notes.
Nextcloud 14 will introduce a complete new search, see nextcloud/server#9912. However, as far as I can see, this will not be backwards-compatible. How to proceed?
The easiest way would be to
- implement new search, but activate it only if the server runs on Nextcloud 14 (how to check this?), and
- remove our search field in the Navigation (since we don't want to implement two searches)
This means, however, that users on Nextcloud 13 or older can't use the search. How do other apps cope with this?
from notes.
@korelstar Apps will need to set their min-version of nextcloud to 14.
The search standard is just a hook so that anyone can use it though. So the differences between a search in 13 and 14 are not that big and search still needs to be managed internally by apps. :)
from notes.
from notes.
Related Issues (20)
- Sort on Note title and Category HOT 1
- Artifacts in the settings window HOT 1
- Ability to turn off rich text editor in the options HOT 3
- Possible bug on Notes app version 4.10.0 HOT 3
- Weird behavior when clicking on text in code block, Firefox browser HOT 1
- Disabling URL previews in text files doesn't fully disable the behaviour HOT 2
- Hyphen does not turn into bullet point when pasting text after it in rich text editor. HOT 1
- Can you add collapsible directory listing in web browser either?
- cannot connect to existing next cloud account HOT 2
- Nextcloud Notes App | Could not load files settings.
- Design polishing HOT 1
- Add SPDX headers
- Icons in settings modal deplaced HOT 2
- Category is not retained when a note is shared HOT 1
- "Failed to overwrite share target for notes" logged when creating guest account (without storage/quota?)
- Hand written notes
- Disable Rich Text Editor Formatting Features
- Notes not showing in webbrowser. HOT 2
- ImageNotWritableException: Controller failed with OCA\Notes\Service\ImageNotWritableException HOT 1
- Windows compatibility: upload a file with wrong filename
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notes.