multiple tags dont work about bookmarks HOT 20 CLOSED

do you have smth in your logs ? (apache, oc, js console, or db)

could you do an export of your bookmark related table of your db?

what is your db system?

Thanks

from bookmarks.

logs are clear, i'm using postgres.
i couldn't find where owncloud stores which bookmark has which tags,
but oc_bookmarks_tags only contains the two seperate tags.

On Thu, Jun 27, 2013 at 11:01 PM, eMerzh [email protected] wrote:

do you have smth in your logs ? (apache, oc, js console, or db)

could you do an export of your bookmark related table of your db?

what is your db system?

Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com/owncloud/bookmarks/issues/20#issuecomment-20154667
.

from bookmarks.

Hi !
I have almost the same problem. Since a few weeks, I cannot add bookmarks with multiple tags.

Here is the error message OC gives me :
Fatal PHP Call to a member function numRows() on a non-object at /var/www/owncloud/apps/bookmarks/lib/bookmarks.php#299

from bookmarks.

I just read another thread and the solution seems linked to 5.0.9 upgrade : https://github.com/owncloud/bookmarks/issues/31

from bookmarks.

i took the code from #31 could you confirm it work for you?

from bookmarks.

Le dimanche 28 juillet 2013 06:40:41 eMerzh a écrit :

i took the code from #31 could you confirm it work for you?

Yes !

Thomas

from bookmarks.

Ok thanks, i close this then ;)

from bookmarks.

it is not resolved for me. as i started this issue, i'd like to reopen it. i used the code from #31 but multiple tags still dont work

from bookmarks.

also, if a bookmark has 2 tags, they are shown as one. but if i completely delete one tag, the other one stays and seems to be intact

from bookmarks.

I can’t reproduce this with the latest code. Please reopen if it still happens.

from bookmarks.

Bump.

this doesn't work for me still..

I'm running:

ii owncloud 5.0.13-1
ii postgresql-9.1 9.1.9-5
and in my apps folder, i'm running

commit 3be88e3
Author: Jenkins for ownCloud [email protected]
Date: Thu Nov 21 21:16:15 2013 -0500

[tx-robot] updated from transifex

for bookmarks

and it drops the damn comma, tags are useless.

=(

from bookmarks.

@eMerzh can you check this out? :)

from bookmarks.

Owncloud 6.0.2 bookmark app behaves exactly as stated by @dnano91 ...

It seems to be possible to assign multiple tags to a bookmark, but you can't use the filter on it.

As soon as a second tag is applied, this tag seems to be concatinated with the first one. So tag "css" and tag "js" becomes a new tag "cssjs".

In owncloud.log I get this error message:

Exception: Doctrine\DBAL\DBALException: An exception occurred while executing 'SELECT * FROM (SELECT *, (select array_to_string(array_agg("tag"),'') from "oc_bookmarks_tags" where "bookmark_id" = "b"."id") as "tags" FROM "oc_bookmarks" "b" WHERE "user_id" = ? ) as "x" WHERE true AND exists (SELECT "id" FROM "oc_bookmarks_tags" "t2" WHERE "t2"."bookmark_id" = "b"."id" AND "tag" = ?) ORDER BY lastmodified DESC LIMIT 10 OFFSET 0': SQLSTATE[42P01]: Undefined table: 7 ERROR: missing FROM-clause entry for table "b" LINE 4: "t2" WHERE "t2"."bookmark_id" = "b"."id" AND "tag" = $2)... ^

from bookmarks.

@mgrobelin I think this is how it should behave. This is like anding the tags.

Assume that you have readlater and it tags as the first comment suggests.

When you click on readlater and it, you are filtering IT sites which you will read later.

After which action do you get this error in log?

CC @jancborchardt?

from bookmarks.

@wakeup I didn't noticed that and behaviour, because the implementation is misleading.

Tags aren't sorted before concatenating, maybe that's the failure then.

Bookmark with Tag ui and Tag css is displayed as uicss
Bookmark with Tag css and ui is displayed as cssui

I would expect to see both Bookmarks with one Tag css and one Tag ui ( =sorted, non-cat'ed)

OR

... both Bookmarks having that one Tag cssui ( =sorted, cat'ed).

from bookmarks.

@wakeup @mgrobelin yeah – tags shouldn’t behave in an »and« fashion in the sidebar. In fact, the sidebar should look more like a sidebar where only one entry is selectable.

@wakeup you want to dig into that? Making it use #app-navigation and #app-content? :)

from bookmarks.

@jancborchardt I will try to look at it, but if anyone else would like to take it, they can feel free :).

I will ask for more info, but need to see the code first :)

from bookmarks.

Assigning it to myself, but anyone can take it.

from bookmarks.

@ruchitarathi this also seems like something for you to dive into the Bookmarks / Readlater stuff. :)

from bookmarks.

Probably fixed with https://github.com/owncloud/bookmarks/pull/68, at least works since OC 7. Please reopen, if you still have the issue.

Mind, there is an regression were adding tags is missing, for this follow there https://github.com/owncloud/bookmarks/issues/127

from bookmarks.