BigQueryType.toTableRow does not serialize properly in lambda when there are custom types about shapeless-datatype HOT 8 CLOSED

BaseBigQueryMappableType extends MappableType which should be Serializable, as we as the other traits here:
https://github.com/nevillelyh/shapeless-datatype/blob/master/core/src/main/scala/shapeless/datatype/mappable/MappableType.scala

We should add a few tests too.

from shapeless-datatype.

We can test serialization for *Type instances with the following snippet.

def ensureSerializable[A](a: A): Unit = {
    val baos = new ByteArrayOutputStream()
    val oos = new ObjectOutputStream(baos)
    oos.writeObject(a)
    oos.close()
    baos.close()
  }

from shapeless-datatype.

Hmm... Looks like we already have a SerializableUtils#ensureSerializable method which is used in most tests. Somehow we missed this. Should just add a test case and fix impl.

from shapeless-datatype.

I'm able to reproduce it with the following snippet:

package shapeless.datatype.bigquery

import shapeless.datatype.test.SerializableUtils

object Test {

  object Color extends Enumeration {
    type Color = Value
    val Red, Green, Blue = Value
  }
  case class Record(i: Int, s: String, c: Color.Value)

  def main(args: Array[String]): Unit = {
    val r = Record(10, "hello", Color.Red)

    implicit val colorType = BigQueryType.at[Color.Value]("STRING")(_ => Color.Red, _.toString)
    val bqt = BigQueryType[Record]

    SerializableUtils.ensureSerializable(bqt)
    val fn = (r: Record) => bqt.toTableRow(r)
    SerializableUtils.ensureSerializable(fn.asInstanceOf[Serializable])
    println(bqt.toTableRow(r))
  }
}

BigQueryType itself is serializeable, but the lambda isn't since it pulls in an implicit colorType

from shapeless-datatype.

Pushed a WIP branch. It's still failing for some edge cases.
https://github.com/nevillelyh/shapeless-datatype/tree/neville/serde-dbg

[info] ! BigQueryType.seqs: Exception raised on property evaluation.
[info] > ARG_0: Seqs([I@1311b9c2,List(),Vector())
[info] > Exception: java.io.NotSerializableException: scala.Array$$anon$2
[info] ! BigQueryType.repeated: Exception raised on property evaluation.
[info] > ARG_0: Repeated(List(),List(),List(),List(),List(),List(),List(),List(),List())
[info] > Exception: java.io.NotSerializableException: scala.collection.generic.GenTraversableFactory$$anon$1
[info] + BigQueryType.date time types: OK, passed 100 tests.
[info] + BigQueryType.required: OK, passed 100 tests.
[info] + BigQueryType.mixed: OK, passed 100 tests.
[info] + BigQueryType.custom: OK, passed 100 tests.
[info] + BigQueryType.optional: OK, passed 100 tests.
[info] + BigQueryType.nested: OK, passed 100 tests.

from shapeless-datatype.

The seqs & repeated failures are caused by CanBuildFrom not serializable. I made a workaround and now it's hitting some implicit lookup issue.

from shapeless-datatype.

So fixed almost everything except for Array[T], since Array.newBuilder requires an (implicit t: ClassTag[T]) argument which isn't available.

from shapeless-datatype.

Fixed in 1445a26 and 39b317b

from shapeless-datatype.