Giter Club home page Giter Club logo

Comments (2)

NeVeSpl avatar NeVeSpl commented on June 2, 2024

What about going in the opposite direction and making Type TypeDefinitionExtensions.ToType(this TypeDefinition typeDefinition) public? Would not be that enough?

I would rather prefer to embrace end-user to use reflection API, instead of Mono.Cecil API which should be an implementation detail hidden from the end-user, but unfortunately this is a way that the original library has taken.

Regarding the second question, it is not possible in the current API, but it is fully supported internally, so the only question is how to expose that through API.

from netarchtest.enhancededition.

cmenzi avatar cmenzi commented on June 2, 2024

What about going in the opposite direction and making Type TypeDefinitionExtensions.ToType(this TypeDefinition typeDefinition) public? Would not be that enough?

I would rather prefer to embrace end-user to use reflection API, instead of Mono.Cecil API which should be an implementation detail hidden from the end-user, but unfortunately this is a way that the original library has taken.

Sure, I can live with that as well and was initially what I've been looking for. :-)

Regarding the second question, it is not possible in the current API, but it is fully supported internally, so the only question is how to expose that through API.

I guess, ICustomRule would need to be anyway redesigned, so that it does not have a visible Mono.Cecil dependency.

I would expect something like a CustomRuleResult.

return new CustomRuleResult(success: true, explanation: "Because of this and that

or

return CustomRuleResult.Success() and CustomRuleResult.Failed("Because of this and that")

But encapsulating all of stuff 'Mono.Cecil` or TypeDefinition and TypeReference would be a lot of work, I guess.

from netarchtest.enhancededition.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.