Giter Club home page Giter Club logo

Comments (8)

NeverSinkDev avatar NeverSinkDev commented on July 28, 2024

Hey, thank you for the issue.

Filterblade takes it's economy data straight from poe.ninja.

The filter generation actually does check the resulting reward, from most unique and currency related div cards.

We'll check if the script for poe.ninja is working correctly

from neversink-filter.

remd avatar remd commented on July 28, 2024

I just realized that my poe.ninja settings were set to Sanctum prices. 😳 I apologize for the incorrect and misleading data.

However, poe.watch was set to Crucible and my trade searches were against Crucible. I think FilterBlade is grabbing the economy data correctly from poe.ninja although I'm not sure why poe.ninja inflates the prices of the cards so much.

from neversink-filter.

remd avatar remd commented on July 28, 2024

Just a passing thought I had on this. Would it be possible to offer fetching prices via poe.watch as an alternative?

They have an API available at https://docs.poe.watch/ and from a cursory look have the same items listed that poe.ninja lists. One thing I see missing is item base types but I don't think FilterBlade offers item base type price import (please correct me if I'm wrong).

At least their divination card prices seem to be much more accurate. Thirst For Knowledge currently sits at 4c on poe.ninja but poe.watch shows it as 1.35c which looks to be much closer to what the trade listings are currently sitting at. From personal experience pricing Orb of Chance, Orb of Fusing, and Delirium Orbs from poe.watch seems to be more accurate with those as well.

from neversink-filter.

jpwalsh1 avatar jpwalsh1 commented on July 28, 2024

div prices are still out of wack, its flagging 1c cards for me when there is no reason why we need to be picking these up

from neversink-filter.

NeverSinkDev avatar NeverSinkDev commented on July 28, 2024

div prices are still out of wack, its flagging 1c cards for me when there is no reason why we need to be picking these up

Please provide context.

Version, strictness, card, price, details etc

from neversink-filter.

jpwalsh1 avatar jpwalsh1 commented on July 28, 2024

12/27

Very Strict

T14 Jungle Valley

Cards that still showed up on filter (all 1c at best)

Emperor's Luck
Lantador's
Fathomless

Very strict should not be showing me 1c cards anymore, or making any noise for them either.

from neversink-filter.

jpwalsh1 avatar jpwalsh1 commented on July 28, 2024

image

Ran a delly map, 10 cards in there the very strict filter told me to pick up. 1 of them is valued more than 1c.

The Lion
The Penitent
The Gemcutter
The Wrath
The Calling
The Trial
Vinia's Token
Lost Worlds
The Wolf

The one worth more than 1c, was The Breach.

Expecting 'economy updates' in the filter, will sort uniques, cards, gems, etc based on the current poe.ninja tables without us needing to go manually edit the loot filter.

from neversink-filter.

NeverSinkDev avatar NeverSinkDev commented on July 28, 2024

Very strict still shows a lot of random cards with potentially interesting outcomes and currency-like items.
Additionally use the latest version, many of the examples are actually hidden.

Emperor's Luck - highly random, fun, grants currency
Lantador's - hidden
Fathomless - hidden
Lion - random outcome with chance for jewel, ok
Penitent - Tricky one, large random pool, hidden on uber-strict as intended, but I see your point here.
Gemcutter - hidden
Wrath - Shown and it's ok
Calling - hidden
Trial - hidden
Vinia's - shown and ok
lost words - hidden
wolf - similar to penitent

Overall:

  • Use latest version
  • Upgrade to uber-strict

I'll be doing some readjustments to the expectations of the individual strictness experience, but your examples seem in the acceptable range.

from neversink-filter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.