Let users define dotenv plugins? about serverless-dotenv-plugin HOT 7 CLOSED

What kind of plugins are we talking about? I like the concept.

from serverless-dotenv-plugin.

We are using dotenv-parse-variables in particular, this is a list of notable dotenv plugins that follow the recommended way:

1. dotenv-conversion
2. dotenv-expand
3. dotenv-packed
4. dotenv-parse-variables
5. dotenv-mustache

There are many other repo that depends on dotenv but works as a wrapper module, but I don't think they can be easily mixed with one another.

from serverless-dotenv-plugin.

Hi @vicary I created a new feature branch that allows you to add any plugin you want. In fact, it's more generic than that. It opens up the possibility of configuring dotenv in many ways. Would you mind doing a code review and testing it out?

The branch is feature/plugins

Let me know if you have any questions.

from serverless-dotenv-plugin.

Hey this looks very good!

Since it's one step away, I would like to further expose the plugin path as something likeserverless.yml:custom.dotenv.configPath (let's start a PR to the branch?), but do you think it should share the basePath setting?

from serverless-dotenv-plugin.

I created PR #48 a couple of days ago. As is, it assumes that the root of your project is where the config file is but I think using basePath will be good enough.

from serverless-dotenv-plugin.

I would actually like to have ability to disable dotenv-expand.
Unfortunately, that is written separately from dotenv and knows nothing about single quotes, because it expects already parsed file.
That way, if you add this to your .env file, current version of serverless-dotenv-plugin would still try to expand it

SHOULD_NOT_EXPAND='some$password(with)#chars'

from serverless-dotenv-plugin.

I will like to close this issue in favour of #48 and #90. Please continue the discussion there.

Thanks!

from serverless-dotenv-plugin.