neuhausneuhaus / simonharderfaster.js Goto Github PK

Hey David!

I hope you are doing well! Great job on this project! I love the Daft Punk!

The first thing I see is that the HTML indentation needs work. Employers will judge you pretty hard on having clean, well-formatted code so be sure to watch that. It does a lot to help others read your code and actually prevents bugs from being introduced. It's can cause the "broken windows" effect.

Consider a building with a few broken windows. If the windows are not repaired, the tendency is for
vandals to break a few more windows. Eventually, they may even break into the building, and if it's
unoccupied, perhaps become squatters or light fires inside.

It's also pretty likely that GitHub is bumping up the indent from tabs and causing chaos. We might want to check your Sublime settings and make sure it's configured to uses "spaces" instead of "tabs" to try and fix this.

var player = new Player; - This seems to work fine, but you should add parentheses here: var player = new Player();

I love your variable names! Great job following the jQuery naming convention! $roundCount. Also, Great object-oriented design and commenting!

I'm a little confused why you are using #over1 from the <audio> tag in your HTML and using JavaScript's new Audio for all the others.

Fantastic Job!