Giter Club home page Giter Club logo

Comments (1)

aquette avatar aquette commented on August 20, 2024

@vencik: here is the result of my review, back in December, aborted due to issues with dummy-ups

  • iirc, this last was not satysfying the sleep delay, when using .seq file (check nut/data)
    That stopped my review
  • a minor remaining concern was that, with svn r3775, we are falling back to perl on Solaris, without being sure it's present... not a big deal since we're in the developer land, and have cascaded deps from autoconf, which requires perl. but still, that's a point that would be good to address.
  • tests were implemented / behaving as expected, apart from the dummy-ups issue, raised above.
    I've also executed some series of tests on the drivers and in general (including upssched), to ensure everything was still doing fine.
  • in common.c->vupslog():
    I'm not a great fan of the start_init boolean method you've used.
    I would d have preferred something in the spirit of the previous implementation, i.e:
    ... start = { 0 };
    ...
    if (start.FIELD == 0) // not init'ed
    ...nut_clock_copytime...

This would require to add a NONE value (set to zero) in nut_clock_mode_t

  • the riello driver, a new driver that has appeared after the MONOTONIC branch completion, needs update.
  • nut_clock.h is somehow redundant with timehead.h, though not addressing the same scope!
    But since timehead.h was in charge of including the right [sys/]time.h, which is now also addressed with nut_clock.h, there should be some possible simplification.

In the same spirit, some reference / update in the developers.txt doc (grep for "timehead.h") would be appreciated.

  • I've committed the "Net-SNMP includes mess" separately (r????).
  • You changed dstate-hal.h (dstate_poll_fds()), but not dstate-hal.c
    not a big deal since this code is dead (I'm keeping it for a potential evolution to upower).
    but I was pretty sure you knew how to use grep ;-p
  • few typo errors here and there

from nut.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.