Comments (3)
Related to https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go
As I can see it has dep on "github.com/networkservicemesh/sdk-sriov/pkg/tools/tokens"
Actually, the dep is using only for https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go#L268
So to remove the dependency on sdk-sriov I would be suggesting just adding the method ToEnv
into https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/main/internal/deviceplugin/server.go#L37.
Then deviceplugin server can be moved into sdk-k8s and can be reusable :)
from cmd-forwarder-sriov.
I am not looking forward to separate ToEnv
and FromEnv
methods to different repos, but I suppose that we can move whole tokens
package to sdk
tools, because it doesn't have any dependencies on some SR-IOV specific stuff.
After that we definitely can move deviceplugin
to the sdk-k8s
.
from cmd-forwarder-sriov.
Summons @Bolodya1997
from cmd-forwarder-sriov.
Related Issues (15)
- Add initial forwarder config initialization HOT 1
- mechanism preferences doesn't work when nsc and nse are in same worker node HOT 2
- Remove redundant test API HOT 2
- Add retries for the method of device plugin ListAndWatch()
- Testing application test/applications/k8s can be removed HOT 2
- Move all tests to separate testing pkg HOT 2
- Add initial CI for cmd-forwarder-sriov repository HOT 2
- Spec: SR-IOV forwarder Device Plugin HOT 2
- Add initial abstract forwarder application
- Add initial docker file
- Apply pattern for cmd repositories HOT 1
- Add interface injection chain element HOT 1
- Add VF selector chain element HOT 2
- Add test Endpoint HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmd-forwarder-sriov.