netcode.io connect tokens fail when letting the system assign a server port. about netcode HOT 2 CLOSED

I did some more digging. The address I'm passing to netcode_generate_connect_token is one I generated by using netcode_server_get_port, which gets the port from server->socket_holder instead of server->address.

Is there a recommended way to update netcode's server->address to include the port that was assigned by the system?

from netcode.

@armandgray heyo, I'm currently trying to debug this issue, and I've run into a roadblock related to your ipv4 + ipv6 PR #60

The bug seems to occur here: https://github.com/networkprotocol/netcode.io/blob/master/netcode.c#L3898

In short, if you bind to port 0, the socket gets assigned a port correctly, but the server->address field is not updated and stays with a port of zero. Incoming connection requests (which have the correct port) all fail because the port on their address (the system assigned port) doesn't match the one in server->address (port 0).

I was going to just take the system assigned port from one of the sockets in the socket holder and update server->address.port, but I imagine that won't work if you have an ipv4 and ipv6 socket on different ports. I think the right approach is to ditch server->address entirely and reference the sockets in socket_holder directly.

That said, I'm not 100% if that's the best approach. Would love your feedback.

Max

from netcode.