Adding Manufacturer specific data into Advertising data about gobbledegook HOT 5 CLOSED

// Start advertising with custom data
// Advertisement packet will contain: flags, shortName, uuid
bool Mgmt::addAdvertising(std::string shortName, const uint8_t* uuid)
{
    constexpr size_t ADVERTISING_SHORTNAME_MAX_LEN = 8;
    constexpr size_t ADVERTISING_UUID_LEN = 16;
    constexpr size_t ADVERTISING_MAX_DATALEN = 2 + ADVERTISING_SHORTNAME_MAX_LEN + 2 + ADVERTISING_UUID_LEN;

    struct SRequest : HciAdapter::HciHeader
    {
        uint8_t  instance;
        uint32_t flags;
        uint16_t duration;
        uint16_t timeout;
        uint8_t  advDataLen;
        uint8_t  scanRspLen;
        uint8_t  data[ADVERTISING_MAX_DATALEN];
    } __attribute__((packed));

    SRequest request;
    request.code = Mgmt::EAddAdvertisingCommand;
    request.controllerId = controllerIndex;
    request.dataSize = sizeof(SRequest) - sizeof(HciAdapter::HciHeader);

    request.instance = 1u;
    request.flags = 3u; // Connectable && Discoverable, see Bluez/lib/mgmt.h
    request.duration = 0;
    request.timeout = 0;

    size_t shortNameEffectiveLen = std::min(ADVERTISING_SHORTNAME_MAX_LEN, shortName.length());
    request.advDataLen = ADVERTISING_MAX_DATALEN - (ADVERTISING_SHORTNAME_MAX_LEN - shortNameEffectiveLen);
    request.scanRspLen = 0;

    request.data[0] = static_cast<uint8_t>(ADVERTISING_UUID_LEN + 1);
    request.data[1] = 0x07; // Incomplete UUID list
    memcpy(&request.data[2], uuid, ADVERTISING_UUID_LEN);

    request.data[2+ADVERTISING_UUID_LEN] = static_cast<uint8_t>(1 + shortNameEffectiveLen);
    request.data[3+ADVERTISING_UUID_LEN] = 0x08;  // Set short name
    memcpy(&request.data[4+ADVERTISING_UUID_LEN], shortName.c_str(), shortNameEffectiveLen);

    if (!HciAdapter::getInstance().sendCommand(request))
    {
	Logger::warn(SSTR << "  + Failed to start advertising with UUID");
	return false;
    }

    return true;
}