Link with captured variable and latte strict mode not working about application HOT 6 CLOSED

Input of link must be string and casting would only hide errors. Even casting just Html would hide errors -> Html instance usually does not make sense to be an input for link.
Capture is mostly for html context so it's also correct to return Html. Maybe it could be made context-aware and always output string for non-html input.
Otherwise I would use explicit casting to string in user code.

from application.

Yeah. But you'd have to do a lot of checks in a lot of places. It would probably be more practical to switch to strictTypes = true in general, or remove Html::__toString(), or modify __toString() to return ASCII.

from application.

Basically I agree, I mentioned it in original @spaze’s issue efabrica-team/phpstan-latte#398

from application.

A similar problem was reported (and fixed) in nette/latte#326, passing Html to img src caused troubles.

Code taken from that issue that didn't work before but not works:

{capture $test}https://nette.org{/capture}
<img src="{$test}">

It's similar enough that I'd say it would make sense for the code used in this issue to also work. What do you think?

from application.

The difference is in the n:href and src. The former contains PHP code and unicode strings, the latter HTML.

{capture $link}foo+bar{/capture}
<img src="{$link}">   ->   <img src="foo&#43;bar">     OK
<a n:href="$link">    ->   <?php $link = 'foo&#43;bar';  // BAD!!!
                                 $link = 'foo+bar';      // THIS IS OK 

from application.

I see, thanks. So just to make sure I understand it correctly, \Nette\Bridges\ApplicationLatte\Nodes\LinkNode should ideally check whether $destination is a string and not an Html object to make sure it works as intended even with $strictTypes = false, is that correct?

from application.