Support v1 Protos (or provide utility to convert) about fenzo HOT 5 CLOSED

Conversion may work for the short term, and that might be the easiest way for you to proceed, I think.

An alternative to supporting v1.Protos.Offer (and any future versions) in Fenzo is a thought to abstract the Offer object in Fenzo and then have a set of Provider implementations for them. So, a v0 user would use the v0 provider, you'd use a v1 provider, etc. However, this could potentially break backwards compatibility due to change in Fenzo's VirtualMachineLease.getOffer() signature. We will have to consider this further.

Additional thoughts welcome.

from fenzo.

That was the general idea I was hoping for. It seems like most Fenzo interfaces abstract away Mesos-specific concepts and use Fenzo data models. Perhaps only Protos.Attribute and Protos.Offer exist as hard ties to the Mesos library. It might be nice to see those get abstracted in the future as well, in favor of adapters/providers as you mention. In the meantime, I'm posting the question to the Mesos community of how to safely convert v1 models to the older models.
Thanks for the feedback!

from fenzo.

FWIW, on Mesos Slack, someone pointed me to this link. The class notes that Mesos uses the same conversion logic internally, so that was good enough for me. It is basically serialize, deserialize... but using the builder.merge.

https://github.com/apache/aurora/blob/c85bffdd6f68312261697eee868d57069adda434/src/main/java/org/apache/aurora/scheduler/mesos/ProtosConversion.java

from fenzo.

Nice, thanks for the update.

from fenzo.

I am thinking that the workaround solves this issue and therefore I'm going to close this. Feel free to reopen this or a new one if needed. Thank you.

from fenzo.