Giter Club home page Giter Club logo

Comments (2)

codefromthecrypt avatar codefromthecrypt commented on July 21, 2024

thanks for the reports, Sanjay. I've consolidated the issues together
so as to not spam watchers.

The meta-issue here is whether to address the RFC compliance in the
rdata types or in the tests, and what to present to users who may not
care about the "letter of the law". Changes might surprise users who
are more interested in portability than growing their knowledge of DNS
nuance.

Bear in mind that literally all current DNS providers pass tests as
they exist today. Some of that was addressed by normalizing in the
provider code. For example, we "unquote" txt in route53
https://github.com/Netflix/denominator/blob/master/route53/src/main/java/denominator/route53/ResourceRecordSetHandler.java#L69

I'm open to ideas for change, but I think that since the context is a
draft provider, we should be on the same page with regards to the
experience impact this might have. copying some other folks for
opinion towards that: @jdamick @jonbodner @colmmacc @MisterK
@everett-toews @jwbraucher

from denominator.

codefromthecrypt avatar codefromthecrypt commented on July 21, 2024

@sanjaympawar1 I would change your parsers so that they pass the tests. Even if the spec says it is ok to change the case (ex. I write 'ABC', but the api stores 'abc'), it is odd that this happens. When you write your README, follow the example here: https://github.com/Netflix/denominator/blob/master/route53/README.md

This issue will linger until others feel strongly we should change our rdata types to follow RFC when doing equals etc. or a week has passed.

from denominator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.