Build warnings (-Wunused-result) fixes about net-snmp HOT 4 CLOSED

I haven't seen any such warnings recently. On which Linux distro did you encounter these warnings?

Additionally, I doubt that this patch is sufficient for all gcc versions. Please introduce a macro for suppressing these warnings such that the implementation of that macro can be modified easily, e.g. something like this (untested):

#define IGNORE_RESULT(e) do { if ((e)) { } } while (0)

from net-snmp.

A macro would indeed be better, though I was not sure where to place the macro.
In my experience (void)! does the job for the gcc / clang versions I used. (Though your macro might be more thorough)

Currently I'm building on Debian 10, gcc 8.3. These of course only come up with a clean build / rebuild of those files, which is why I usually prefer building with -Werror.

If you're not seeing them, it may have something to do with the configuration I am building with.
Some details about the flags I send to the configure tool: (note I added -Werror).

NETSNMP_CFG     += --silent
NETSNMP_CFG     += --enable-static
NETSNMP_CFG     += --disable-shared
NETSNMP_CFG     += --disable-embedded-perl
NETSNMP_CFG     += --disable-perl-cc-checks
NETSNMP_CFG     += --disable-manuals
NETSNMP_CFG     += --without-root-access
NETSNMP_CFG     += --with-defaults
NETSNMP_CFG     += --with-mib-modules=snmp-usm-dh-objects-mib
MIBS_REMOVE     += notification-log-mib snmp-notification-mib
MIBS_REMOVE     += agentx ucd_snmp target utilities
MIBS_REMOVE     += disman/event disman/schedule host
NETSNMP_CFG     += --with-out-mib-modules="$(MIBS_REMOVE)"
NETSNMP_CFG     += --without-pcre
NETSNMP_CFG     += --without-nl

OPENSSL_DIR      = $(SDKTARGETSYSROOT)/usr
NETSNMP_CFG     += --with-openssl="$(OPENSSL_DIR)"
NETSNMP_CFG     += --with-cflags="-fPIC -fpic -g -I$(OPENSSL_DIR)/include -O2 -Werror"
NETSNMP_CFG     += --with-ldflags="-g -lcrypto -L$(OPENSSL_DIR) -ldl"

from net-snmp.

I have been able to reproduce the reported warnings by building the Net-SNMP code with -D_FORTIFY_SOURCE=1. A patch that fixes these warnings has been checked in. Please update your local copy of the Net-SNMP code and retest.

from net-snmp.

I just verified this to be working.

from net-snmp.