`AttachedOnEditor` is being screwed up when Merging crafts about ksp-recall HOT 13 CLOSED

Additional instrumentation on TweakScale just confirmed what I already now - that TweakScale does not do any math on the part when it is not scaled, so the original misbehaviour is still unexplained at this time.

So I don't really know why it happened at first place.

So I don't know why the changes made for this issue solved the issue.

(deep sigh)

I'm counting my blesses know. I will push this thing into production and then hire a priest to execute an exorcism on this damned thing.

from ksp-recall.

The behaviour is not consistent. It changes depending of the part!!!

On MK1 cockpits, there's no gap - but clipping inside!!!!

DAMN!!

The behaviour is consistent with the Mk2, saving and reattaching solving the glitch. But, again, DAMN!!!

from ksp-recall.

IT'S A FSKCING ROUNDING PROBLEM!!!

When we save the AA vessel (the two A ones merged), the vessel Y size is being set to 10.49992 M.

When I saved AA again as AA2, the Y size is now 10 M, the correct size because now I can deatach and reattach the damned thing into the right place.

On the A file, the Y size is correctly set to 5 M.

from ksp-recall.

Removing TweskScale from the GameData "solves" the issue, so this is really some misbehaviour caused (or induced) by TweakScale.

from ksp-recall.

Interesting:

When you load the craft file, everything works fine. When you "load for merge", things are completely screwed.

If TweakScale would be at fault, loading the resized A craft would trigger the problem too.

So it's not something TweakScale is doing wrong. It's something someone (TweakScale or Recall) is not doing right.

Time to mess with AttachedOnEditor to see what I get.

from ksp-recall.

HA!! I found two problems!

The gap on unscaled parts is something on KSP-Recall. But the clipping parts it's something else. Since the original problem is the gap, I'm transferring back this issue to KSP-Recall.

from ksp-recall.

HOLY KRAP. Again.

KSP's Editor behaviour differs when loading a subassembly from loading a craft for merge. This is completely bonkers.

Whoever wrote that code for KSP 1.4.x, he/she/it/whatever didn't programmed a feature. he/she/it/whatever hacked and sliced and butchered the way out of the task. (sigh)

Damn… How I was naive a couple years ago...

from ksp-recall.

The misbehaviour is consistent from KSP 1.4.3 to KSP 1.12.5 :

When using a subassembly, everything works fine.

When merging a craft, that crappy gap happens.

Oukey, this is not a bug on TweskScale neither Recall. Is a new bug from KSP that I only realised today.

from ksp-recall.

It's a BUG on KSP, so it's not my fault.

from ksp-recall.

(almost) fixed on commit 9649697

There's still a gap, however. Still digging.

from ksp-recall.

Oukey, we still have the misbehaviour - it only happens to be smaller now.

Still the same effect, only smaller:

from ksp-recall.

Apparently commit 8d58433 fixes this second misbehaviour (smaller gap).

But I'm pretty unsatisfied with this stunt. I think there's a float wounding lurking somewhere in TweakScale - but where it would be it's beyound me right now. This issue was also happening with unscaled parts, and TweakScale just don't do any math on unscaled parts! (or should not)

from ksp-recall.

I'm counting my blesses know. I will push this thing into production and then hire a priest to execute an exorcism on this damned thing.

The priest was fired. We are hiring!

from ksp-recall.