Nest can't resolve dependencies of the JwtAuthenticationGuard after upgrade 8.1.0 to 8.1.1 about passport HOT 9 CLOSED

@jmcdo29 I looked at lib/auth.guard and I saw this In order to use "defaultStrategy", please, ensure to import PassportModule in each place where AuthGuard() is being used. Otherwise, passport won't work correctly..

Then, I added PassportModule.register({}) (only PassportModule don't work) in all the modules that use @UseGuards(JwtAuthenticationGuard) and it works with 8.1.1

from passport.

Only if

1. you have a PassportModule.register() with options you want to have used (like user property )
2. You have a guard that needs to AuthService

Otherwise, it shouldn't really be necessary, but it is at the moment because of the change

from passport.

@cleytoncoro if you'd read the above comments in the issue, and the linked PR, you'd realize this already has a fix, and there's solutions in the thread already. Kamil will most likely publish a patch or minor update for this once the PR is merged.

from passport.

For a quick workaround, use PassportModule.register({}) instead of just PassportModule. I'll have a fix up for this later.

Thanks for reporting it it. I'll make sure the test suite gets updated with a case to cover this

from passport.

@jmcdo29 I tried, but it still doesn't work. I went back to 8.1.0. I'm just learning. Thanks.

from passport.

Okay, yeah, that tracks. I was using a single module setup for testing this. You would need to use the PassportModule.register({}) and then have your AuthModule have PassportModule in the exports and ensure that AuthModule was imported wherever you use the AuthGuard().

Turns out, I needed to add @Optional() to the property injector as well, so the fix is easy, it's just making sure our test suite is updated now

from passport.

@jmcdo29 in a normal situation (without this issue), should I always import AuthModule in all modules I use UseGuards?

from passport.

Following nest docs (https://docs.nestjs.com/security/authentication) i found this error too after implementing local strategy (after "Implementing Passport local" topic and before "Built-in Passport Guards").

Downgrading to 8.1.0 all things works fine.

I'm start learning nestjs and I don't now how to colaborate sending PR. Maybe this repo needs an update, or maybe nestjs docs needs to be updated.

from passport.

Fixed

from passport.