LoggerService transforms the instance of Error when controller throws an Error about nest HOT 3 CLOSED

See packages/core/exceptions/base-exception-filter.ts in the NestJS source code:

  public handleUnknownError(
    exception: T,
    host: ArgumentsHost,
    applicationRef: AbstractHttpAdapter | HttpServer,
  ) {
    const body = this.isHttpError(exception)
      ? {
          statusCode: exception.statusCode,
          message: exception.message,
        }
      : {
          statusCode: HttpStatus.INTERNAL_SERVER_ERROR,
          message: MESSAGES.UNKNOWN_EXCEPTION_MESSAGE,
        };

    const response = host.getArgByIndex(1);
    if (!applicationRef.isHeadersSent(response)) {
      applicationRef.reply(response, body, body.statusCode);
    } else {
      applicationRef.end(response);
    }

    if (this.isExceptionObject(exception)) {
      return BaseExceptionFilter.logger.error(
        exception.message,
        exception.stack,
      );
    }
    return BaseExceptionFilter.logger.error(exception);
  }

  public isExceptionObject(err: any): err is Error {
    return isObject(err) && !!(err as Error).message;
  }

If your error is an instance of Error, then the error logs a concatenation of the error message and stack, not the Error object itself.

from nest.

@sinapirani that means we need to have our own filter if we want to get the Error object 🤔

Should we really rely on that? For me, many people want to use their custom logger (like Winston, Pino, etc) and they have their way to parse the error logs. That means if they want to catch this logs, they need to implements LoggerService + NestInterceptor or an exception filter?

My current solution was to build something like this:

@Injectable()
export class ErrorInterceptor implements NestInterceptor {
  intercept(context: ExecutionContext, next: CallHandler): Observable<unknown> {
    return next.handle().pipe(
      catchError((error) => {
        logger.error(error);

        return throwError(() => {
          if (error instanceof HttpException) {
            return error;
          }

          return new HttpException(
            {
              statusCode: 500,
              message: 'Internal server error',
            },
            500,
            { cause: error },
          );
        });
      }),
    );
  }
}

from nest.

That's the expected behavior.

From the looks of it, this could be better discussed on our Discord. If you haven't already, please join here and send a new post in the #⁠ 🐈 nestjs-help forum. Make sure to include a link to this issue, so you don't need to write it all again. We have a large community of helpful members, who will assist you in getting this to work.

from nest.