Giter Club home page Giter Club logo

Comments (5)

Deepak1100 avatar Deepak1100 commented on June 18, 2024

The problem is at this line
https://github.com/ivx/yet-another-cloudwatch-exporter/blob/master/aws_cloudwatch.go#L373

as label_key is same it's getting override

from yet-another-cloudwatch-exporter.

thomaspeitz avatar thomaspeitz commented on June 18, 2024

Thanks for your awesome description. Will check this out in the next day and rethink how we can solve that with some nice user experience.

The use cases are so different and cloudwatch api is a mess.

Currently rethinking if it makes more sense to implement each metric itself e.g. elb and then allow setting: "queryAvailabilityZones: true" or something like that. That setup would allow setup of #59 as well.

Will come back to you.

from yet-another-cloudwatch-exporter.

Deepak1100 avatar Deepak1100 commented on June 18, 2024

@thomaspeitz I have created this PR
https://github.com/ivx/yet-another-cloudwatch-exporter/pull/74/files

and it will make cloudwatch list metrics API call. So it will increase overall cloudwatch API calls
but it will be more generic and will work on almost all available type

I have tested it locally seems its working fine over there.
Let me know your thoughts.

from yet-another-cloudwatch-exporter.

thomaspeitz avatar thomaspeitz commented on June 18, 2024

Thanks :) - I guess i will do review this friday :)

from yet-another-cloudwatch-exporter.

thomaspeitz avatar thomaspeitz commented on June 18, 2024

Already merged. Thanks!

from yet-another-cloudwatch-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.