Giter Club home page Giter Club logo

Comments (3)

doronbehar avatar doronbehar commented on June 5, 2024 1

Thanks for the links! Indeed only deleting the umask line in main.c doesn't help the attachments scenario. Removing Changing the 0600 argument in the mutt/file.c file, does make the running shell's umask be honored by mutt. use different permission.

Now with the provided pointers, it should be fairly easy to create a configuration option that will make neomutt honor umask at least for saving attachments. I'd like to work on that, if you'd accept the feature.

from neomutt.

roccoblues avatar roccoblues commented on June 5, 2024

It would have been great if neomutt would have honored umask, or if it would have been possible to configure it to honor umask settings.

I had a brief look into this. Seems like we override the umask during startup:

neomutt/main.c

Line 557 in 8e3ea66

umask(077);

However, even if we wouldn't do that, we explicitly create files with permission 0600, so no matter the umask you could never add bits for the group.

fd = open(buf_string(&safe_file), flags, 0600);

from neomutt.

roccoblues avatar roccoblues commented on June 5, 2024

Now with the provided pointers, it should be fairly easy to create a configuration option that will make neomutt honor umask at least for saving attachments.

Based on my experience nothing is "easy" in NeoMutt land. 😏

I'd like to work on that, if you'd accept the feature.

Thank you for working on this already! I left some early thoughts. I'm also just a contributor so we need @flatcap's opinion here.

from neomutt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.