Comments (8)
And maybe in return you could consider contributing your notification library to plenary? It's really quite lovely, and I'd love to use it as a vim.notify provider...
I don't think there is any point, because the library is already part of neovim ui
from neogit.
I am also working on async await jobs as a follow up pr.
from neogit.
async
await
jobs are here! link
from neogit.
I think depending on plenary is good, as much of plenary will likely make it into core at some point, and the async PR has a high likelihood of being merged.
from neogit.
async await was merged!
from neogit.
I also feel like depending on plenary is a none issue, since a lot of plugins are already using the "library". Like @mjlbach said, I also think that most of the plenary stuff will make it into core (mostly because tj is the owner of the library).
Changing from our own solution to the async lib from plenary is probably a good idea 👍
from neogit.
And maybe in return you could consider contributing your notification library to plenary? It's really quite lovely, and I'd love to use it as a vim.notify
provider...
(Apropos: Not worth its own issue, but it'd look nicer if the notification highlight groups were linked to standard highlight groups -- like MoreMsg
, WarnMsg
, and ErrMsg
-- rather than specific colors. I haven't tested it but from the code it looks like these are set unconditionally, so they would override the ones from a user's init.vim
or color scheme should they set them there?)
from neogit.
@oberblastmeister thanks for all the work you put into it, looks amazing!
from neogit.
Related Issues (20)
- Status - Mapping of `o` is broken now HOT 1
- `use_default_keymaps = false` does not do anything HOT 1
- Setting a hotkey to `false` errors out at startup
- Neogit fails to start when an untracked file name is just a number
- Some neogit buffers break `statuscolumn` HOT 1
- Can't handle `typechange`
- Chevron rendering issues? HOT 1
- exception when initing a new repo (windows + wsl) HOT 1
- Unnamed buffers left in buffer list after closing Neogit
- Fails to parse diffs with submodule changes HOT 1
- "Go to file" is not working HOT 12
- Quitting a Neogit tab should focus previously focused tab HOT 2
- Cannot close last window HOT 1
- Cursor jumps to the top of the screen when saving a file when Neogit is open HOT 1
- Suggestion: Submit commit if .git/COMMIT_EDITMSG is saved and closed HOT 2
- Neogit not workign after update - neogit has not been setup HOT 2
- Errors around stash pop
- Properly Colored Unicode Graphs
- `:Neogit blame` HOT 1
- [Enhancement] Programatially Execute popup actions or switches without showing them HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neogit.