Comments (4)
That might work for a normal commit, but for an amend we need to load the previous commit message.. There's just a lot of added complexity here to mask over the real issue - slow hooks. I'd be open to see a POC, but I don't think this is something I'm going to investigate in the foreseeable future.
from neogit.
So, this is a great idea, but I don't think its possible with the current way the whole commit message flow works. We basically just hijack git opening $EDITOR by providing some RPC server for it to talk to. But, we're bound by gits semantics here, which means first the hooks run 🤷♂️
If you're curious, you can check out client.lua to see the rpc stuff
from neogit.
So, this is a great idea, but I don't think its possible with the current way the whole commit message flow works. We basically just hijack git opening $EDITOR by providing some RPC server for it to talk to. But, we're bound by gits semantics here, which means first the hooks run 🤷♂️
Ah that makes sense - thanks for the quick response.
I suppose one alternative would be to have a config option that lets you compose the commit message before executing git commit
at all, probably making use of a temporary file and something like git commit --file /tmp/neogit-commit-message
.
I think I'd make use of an option like that if it were available. It wouldn't actually make the whole commit process take any less time, but it might feel a bit more snappy.
from neogit.
That's understandable - if I'm feeling really motivated to at some point, I might come back here with a POC.
from neogit.
Related Issues (20)
- [Bug] Issues with keymaps persist HOT 6
- No way to manually open console HOT 5
- Feature request: Set buffer options in gitcommit/NeogitCommitMessage filetype
- Attempt to index local 'diff' (a nil value) HOT 4
- Opening Neogit: bisect.lua:91: Attempt to index local 'oid' (a nil value) HOT 1
- Status not being automatically refreshed when staging / unstaging / commiting / pushing on Windows HOT 27
- Neogit misreads Nvim version HOT 1
- Support to custom keymap for navigation? (h,j,k,l)
- Can't unmap "u" key in status HOT 5
- Add Diff Arguments Support
- Push refspec support HOT 1
- issue with kind=replace HOT 5
- Using the default config from README.md does not work HOT 1
- vim.wait must not be called in a lua loop callback HOT 13
- Open Current Branch in Browser HOT 1
- Using ":Neogit branch" to create a branch leads to error
- Error "Neogit has not been setup!" HOT 2
- Neogit doesn't respond to subcomands
- Error when committing HOT 1
- closing commit_editor with kind = "vsplit" causes error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neogit.