Multitude of keymap issues during user customization about neogit HOT 6 CLOSED

Yeah, fair points. I won't pretend that the existing API is ideal - I think it would be much nicer to pretty much copy what telescope does, and allow users to bind functions directly.

This isn't something very high on my list right now, but I'd welcome any pull request that goes in the direction of telescope - doesn't need to be you, but if you're up for it I can help point you in the right direction :)

from neogit.

On the nightly branch you can now set separate insert mode mappings for submit and abort.

from neogit.

@CKolkey this does not however address the initial request. Please revisit the description of this issue, there are more than one issues. And i immediately hit the same issue with master branch. Where if i have even 1 missing keymap, the entire neogit fails to start (with use_default_mappings = false). For example updating to master i was missing "untrack" mapping, and neogit just chokes, and fails to init.

from neogit.

Not addresssed here yet

I would like to customize / provide only a specific set of actions in the keymaps with use_default_keymaps = false, and have only those be mapped for editors, popups, status etc, the ones which remain unused, should not prevent the user from interacting with neogit

I would like to have use_default_keymaps = true, and neogit consider correctly the user config and merge the keymaps against the defaults without duplicate keymaps errors. (obviously if the user's config itself contains duplicates between the different keymap sections, that is fine to throw an error)

from neogit.

@asmodeus812 you didn’t ask me, I’m not a maintainer of this project (only contributed a few small things), but having maintained other projects my recommendation would be to create a separate issue for each issue.

With separate issues you can provide a clean and clear reproduction for each issue (easier to write tests) and people who want to use that style of config can rally behind it (maybe even help fix/implement) as well. Of course the issues can link to each other (and back to this one) since they are similar and related.

Edit: I see #1302 has been created, my recommendation would be to split it, since the “true” and “false” cases are quite different. Of course the actual maintainers may have a different opinion, this is just mine.

from neogit.

I suggest we keep this one closed, since it is also containing some issues that are solved already. But for the rest they are all connected to issues with the keybindings. Mostly revolving around how the use_default_keymaps works.

from neogit.