Giter Club home page Giter Club logo

Comments (7)

michael-simons avatar michael-simons commented on May 25, 2024 1

This has been addressed in all driver versions (4.1, 4.2 and 4.3). Thank you.

See: https://github.com/neo4j/neo4j-java-driver-spring-boot-starter/releases/tag/4.2.7.0

from neo4j-java-driver-spring-boot-starter.

lilianaziolek-wayfair avatar lilianaziolek-wayfair commented on May 25, 2024

To further clarify, I am on Spring Boot 2.4 and tried with both implementation("org.neo4j.driver:neo4j-java-driver:4.2.0") and implementation("org.neo4j.driver:neo4j-java-driver-spring-boot-starter:4.2.4.0") as dependencies and the result is the same - not sure if it's the right place for the issue, if not please let me know where it should be reported.

from neo4j-java-driver-spring-boot-starter.

michael-simons avatar michael-simons commented on May 25, 2024

Hi @lilianaziolek-wayfair There's little I can do about that :( It's because the Java driver - not this shim here - is creating a background non-daemon thread. If you close it manually, the app will close.

Of course the driver is registered as a auto closable resource with the application and it will be safely stopped when the application is stopped, but that behavior is expected to happen. Please feel free to raise that over there: https://github.com/neo4j/neo4j-java-driver/issues

from neo4j-java-driver-spring-boot-starter.

lilianaziolek-wayfair avatar lilianaziolek-wayfair commented on May 25, 2024

@michael-simons Do you have any more details on where this thread is created / how to get hold of it to stop it?

from neo4j-java-driver-spring-boot-starter.

michael-simons avatar michael-simons commented on May 25, 2024

It's an internal Netty thread I think… maybe @injectives or @gjmwoods can shed a light.

from neo4j-java-driver-spring-boot-starter.

michael-simons avatar michael-simons commented on May 25, 2024

Coming back to this @lilianaziolek-wayfair:

I am working on a patch for the driver that demonizes our event loop threads correctly and wether it affects our tests or not. We think that this is pretty much a no-brainer, especially as it will be the default in Netty5 at some day: netty/netty#2832

Thanks for bringing this up!
It's not like that I haven't been annoyed by this behavior beforehand.

from neo4j-java-driver-spring-boot-starter.

lilianaziolek-wayfair avatar lilianaziolek-wayfair commented on May 25, 2024

Wonderful to hear! Thanks and let me know if you need a guinea pig to test anything :)

from neo4j-java-driver-spring-boot-starter.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.